KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)#11775
Conversation
C0urante
changed the title
|
Converting to draft until upstream PRs are reviewed. |
C0urante
force-pushed
the
kafka-10000-config-changes
branch
from
c014300 to
69d63ed
Compare
There was a problem hiding this comment.
Not for this PR, but looking at this made me realise that ConfigDef could benefit from a Validator specifically for enums. There's currently inconsistency around case sensitivity, for instance. And using enumOptions more widely would simplify other call sites which typically list all the enum members. Wdyt?
There was a problem hiding this comment.
Definitely agree! Some of the rough edges around, e.g., the consumer isolation.level property and its case-sensitive parsing have been a little troublesome. It'd be great to abstract+simplify some of the logic there and also add some user-facing consistency with how these types of properties are parsed.
KIP-713 may be the place to discuss this kind of effort. It's unclear how much we really care about protecting the various out-of-the-box Validator instances that we ship as "public interface", but I chose to err on the side of caution here since the second we add one for enums, people are going to start using it, so we'd better get it right the first time. This seems like exactly the sort of thing that the KIP process helps facilitate: making careful, measure-twice-cut-once changes to public-facing parts of the project.
C0urante
force-pushed
the
kafka-10000-config-changes
branch
from
c0254da to
48aad48
Compare
|
Marking ready for review since #11773, though not yet merged, has been approved. |
|
@C0urante , there's checkstyle error. Please help fix. Thanks. |
|
Sorry @showuon, should be good to go now. |
|
@showuon is there anything left you'd like me to address? |
|
@C0urante , thanks for the reminder! |
C0urante
force-pushed
the
kafka-10000-config-changes
branch
from
d0e2a33 to
f28d8f8
Compare
C0urante
force-pushed
the
kafka-10000-config-changes
branch
from
f28d8f8 to
2cf98db
Compare
|
@showuon how long would you like to wait before merging this if we don't hear back? |
|
Thanks for your reminder. Merged into trunk. |
4 participants
Adds the new connector- and worker-level properties described in KIP-618.
Relies on changes from:
Note that these properties have no effect on the behavior of the Connect framework (beyond some rudimentary config validation checks) in this PR. The behavioral changes for these properties will be implemented in downstream PRs.