Skip to content

KAFKA-14193: Update expected task configs for FileStream source and sink connectors in ConnectRestApiTest#12576

Merged
C0urante merged 1 commit intoapache:trunkfrom
yashmayya:KAFKA-14193-2
Aug 31, 2022
Merged

KAFKA-14193: Update expected task configs for FileStream source and sink connectors in ConnectRestApiTest#12576
C0urante merged 1 commit intoapache:trunkfrom
yashmayya:KAFKA-14193-2

Conversation

@yashmayya
Copy link
Copy Markdown
Contributor

  • ConnectRestApiTest is currently failing on trunk and 3.3 with the following assertion error:
AssertionError()
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 183, in _do_run
    data = self.run_test()
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 243, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 433, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/opt/kafka-dev/tests/kafkatest/tests/connect/connect_rest_test.py", line 106, in test_rest_api
    self.verify_config(self.FILE_SOURCE_CONNECTOR, self.FILE_SOURCE_CONFIGS, configs)
  File "/opt/kafka-dev/tests/kafkatest/tests/connect/connect_rest_test.py", line 219, in verify_config
    assert config_def == set(config_names)

@yashmayya
Copy link
Copy Markdown
Contributor Author

@C0urante since you also reviewed #12450, could you please review this system test fix whenever possible?

Copy link
Copy Markdown
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified by running locally with a small adjustment to disable assertions that are failing due to KIP-618-related changes.

Never mind, was testing against the KAFKA-14193 branch instead of KAFKA-14193-2. Testing on the correct branch now...

@C0urante C0urante self-requested a review August 31, 2022 20:11
Copy link
Copy Markdown
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, tested the right branch this time. Still had to make adjustments for KIP-618, but everything else worked perfectly. 🎉

@C0urante C0urante merged commit 8a19f2d into apache:trunk Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants