Skip to content

KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest#12575

Closed
yashmayya wants to merge 1 commit intoapache:trunkfrom
yashmayya:KAFKA-14193
Closed

KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest#12575
yashmayya wants to merge 1 commit intoapache:trunkfrom
yashmayya:KAFKA-14193

Conversation

@yashmayya
Copy link
Copy Markdown
Contributor

  • ConnectRestApiTest is currently failing on trunk and 3.3 with the following assertion error:
AssertionError()
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 183, in _do_run
    data = self.run_test()
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 243, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 433, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/opt/kafka-dev/tests/kafkatest/tests/connect/connect_rest_test.py", line 106, in test_rest_api
    self.verify_config(self.FILE_SOURCE_CONNECTOR, self.FILE_SOURCE_CONFIGS, configs)
  File "/opt/kafka-dev/tests/kafkatest/tests/connect/connect_rest_test.py", line 219, in verify_config
    assert config_def == set(config_names)

@yashmayya
Copy link
Copy Markdown
Contributor Author

@C0urante @jsancio could you please take a look at this whenever possible?

@C0urante
Copy link
Copy Markdown
Contributor

This is already addressed in #11783. I'm not sure we can backport that to the 3.3 release branch but I'd like to try given that it has a few other low-risk quality-of-life improvements for Connect and was used to verify KIP-618 for the 3.3 release. If absolutely necessary, we can backport just this change, but I'd like to wait for a bit before making that call.

@C0urante
Copy link
Copy Markdown
Contributor

C0urante commented Sep 8, 2022

Now that we've merged and backported #11783, this should hopefully no longer be necessary. @yashmayya let me know if anything still fails; otherwise, we may want to close this PR.

@jsancio
Copy link
Copy Markdown
Member

jsancio commented Sep 8, 2022

I am going to close the PR. @yashmayya feel free to open the PR if you disagree.

@jsancio jsancio closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connect tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants