KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest#12575
Closed
yashmayya wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest#12575yashmayya wants to merge 1 commit intoapache:trunkfrom
yashmayya wants to merge 1 commit intoapache:trunkfrom
Conversation
…onnectRestApiTest
Contributor
Author
Contributor
|
This is already addressed in #11783. I'm not sure we can backport that to the 3.3 release branch but I'd like to try given that it has a few other low-risk quality-of-life improvements for Connect and was used to verify KIP-618 for the 3.3 release. If absolutely necessary, we can backport just this change, but I'd like to wait for a bit before making that call. |
This was referenced Aug 31, 2022
3 tasks
Contributor
|
Now that we've merged and backported #11783, this should hopefully no longer be necessary. @yashmayya let me know if anything still fails; otherwise, we may want to close this PR. |
Member
|
I am going to close the PR. @yashmayya feel free to open the PR if you disagree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trunkand3.3with the following assertion error:On closer inspection, this is because of the new source connector EOS related configs added in KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618) #11775.
Adding the following new configs -
offsets.storage.topic, transaction.boundary, exactly.once.support, transaction.boundary.interval.msin the expected config defs here fixes the tests on the 3.3 branch. However, the tests still fail on trunk due to the changes from KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors #12450.The plan to fix this is to raise two PRs against trunk patching
connect_rest_test.py- the first one fixing the EOS configs related issue which can be backported to 3.3 and the second one fixing the issue related to propagation of full connector configs to tasks which shouldn't be backported to 3.3 (because the commit from KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors #12450 is only on trunk and not on 3.3)This is the first of the two PRs and should be backported to
3.3