KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows#1261
Closed
miguno wants to merge 5 commits into
Closed
KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows#1261miguno wants to merge 5 commits into
miguno wants to merge 5 commits into
Conversation
Contributor
Author
|
Three tests are failing, stay tuned. |
Contributor
Author
|
Works now. |
| return new TimeWindows(this.name, this.size, hop); | ||
| } | ||
|
|
||
| // TODO: Document windowsFor() |
Contributor
There was a problem hiding this comment.
@miguno I guess you'll remove this TODO as part of PR? Thanks.
Contributor
|
LGTM, tests pass for me (above failure seems to be unrelated). |
Contributor
Author
|
Closed in favor of #1277 (which rebases the changes in this PR on latest Kafka trunk). |
asfgit
pushed a commit
that referenced
this pull request
Apr 29, 2016
…indows This PR includes the same code as #1261 but is rebased on latest trunk. Author: Michael G. Noll <michael@confluent.io> Reviewers: Matthias J. Sax, Guozhang Wang Closes #1277 from miguno/KAFKA-3613-v2
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
…indows This PR includes the same code as apache#1261 but is rebased on latest trunk. Author: Michael G. Noll <michael@confluent.io> Reviewers: Matthias J. Sax, Guozhang Wang Closes apache#1277 from miguno/KAFKA-3613-v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@guozhangwang @enothereska @mjsax : Feel free to take a look.
Beyond the consolidation of windows, I also added further unit tests, merged
equalsToandequals, and renamedevery()toshiftedBy().