KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows#1277
Closed
miguno wants to merge 6 commits into
Closed
KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows#1277miguno wants to merge 6 commits into
miguno wants to merge 6 commits into
Conversation
Contributor
Author
|
@guozhangwang feel free to review (/cc @enothereska and @mjsax ). |
| .countByKey(HoppingWindows.of("GeoPageViewsWindow").with(7 * 24 * 60 * 60 * 1000), Serdes.String()) | ||
| .countByKey(TimeWindows.of("GeoPageViewsWindow", 7 * 24 * 60 * 60 * 1000L).shiftedBy(1000), Serdes.String()) | ||
| // TODO: we can merge ths toStream().map(...) with a single toStream(...) | ||
| .toStream() |
Contributor
There was a problem hiding this comment.
This is out of the scope of this PR but may just be OK do to together: since now we have added the toStream(map) function to KTable, we can actually get rid of this TODO.
- Properly compute windows for a given timestamp (honoring window start time) - Add unit tests/spec, notably to forbid negative window start times
Contributor
|
LGTM overall. Just a couple of minor comments. |
Contributor
|
@miguno Could you address the second comment above? No further reviews needed after that. |
| import java.util.Map; | ||
|
|
||
| /** | ||
| * The window specifications used for joins. |
| * The hop size's effective time unit is determined by the semantics of the topology's | ||
| * configured {@link org.apache.kafka.streams.processor.TimestampExtractor}. | ||
| * The size of the window's advance interval, i.e. by how much a window moves forward relative | ||
| * to the previous one. The interval's effective time unit is determined by the semantics of |
Member
|
+1 |
Contributor
|
LGTM. Merged to trunk. |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
…indows This PR includes the same code as apache#1261 but is rebased on latest trunk. Author: Michael G. Noll <michael@confluent.io> Reviewers: Matthias J. Sax, Guozhang Wang Closes apache#1277 from miguno/KAFKA-3613-v2
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the same code as #1261 but is rebased on latest trunk.