KAFKA-3440: update JavaDoc#1287
Closed
mjsax wants to merge 3 commits into
Closed
Conversation
Member
mjsax
commented
Apr 28, 2016
mjsax
commented
- add class doc for KTable, KStream, JoinWindows
- add missing @return tags
Member
Author
|
@guozhangwang @miguno @enothereska Please review. I guess this should get merged last. Might need to rebase after #1277 and #1250 got merged. |
Member
Author
|
@miguno @guozhangwang @enothereska Just updated this. |
Contributor
There was a problem hiding this comment.
"The time... or both." This may be confusing for developers as it seems they can set the window size parameter as negative values. I recommend removing this sentence as the follow-up example is sufficient.
- add class doc for KTable, KStream, JoinWindows - add missing @return tags
mjsax
force-pushed
the
kafka-3440-JavaDoc
branch
from
1e4033d to
04364aa
Compare
Member
Author
|
@guozhangwang Just updated this PR. Addressing your comments and rebased to latest trunk. |
Contributor
|
Thanks for the patience, @mjsax. LGTM! |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.