KAFKA-3631: Fix Struct.toString for nullable arrayOf#1279
Closed
granthenke wants to merge 3 commits into
Closed
Conversation
| assertFalse("Stuct string should not be empty.", stuctStr.isEmpty()); | ||
| } catch (Throwable e) { | ||
| fail("Struct.toString throws an exception"); | ||
| } |
Member
There was a problem hiding this comment.
Is it really worth having this catch here? I think it's best to just let the exception propagate. Any method under test can throw an unknown exception after all.
| @Test | ||
| public void testToString() { | ||
| String stuctStr = this.struct.toString(); | ||
| assertFalse("Stuct string should not be null.", stuctStr == null); |
Contributor
|
LGTM! |
Member
|
LGTM |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Grant Henke <granthenke@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#1279 from granthenke/struct-fix
efeg
added a commit
to efeg/kafka
that referenced
this pull request
May 29, 2024
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.