Skip to content

KAFKA-3631: Fix Struct.toString for nullable arrayOf #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
granthenke wants to merge 3 commits into from
Closed

KAFKA-3631: Fix Struct.toString for nullable arrayOf #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a1a675
KAFKA-3631: Fix Struct.toString for nullable arrayOf
granthenke Apr 27, 2016
07be584
Remove exception check
granthenke Apr 27, 2016
cfad93d
Address feedback
granthenke Apr 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ public String toString() {
Field f = this.schema.get(i);
b.append(f.name);
b.append('=');
if (f.type() instanceof ArrayOf) {
if (f.type() instanceof ArrayOf && this.values[i] != null) {
Object[] arrayValue = (Object[]) this.values[i];
b.append('[');
for (int j = 0; j < arrayValue.length; j++) {
Expand Down
8 changes: 8 additions & 0 deletions clients/src/test/java/org/apache/kafka/common/protocol/types/ProtocolSerializationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.fail;

import java.nio.ByteBuffer;
Expand Down Expand Up @@ -231,6 +232,13 @@ public void testReadNegativeBytesSize() {
}
}

@Test
public void testToString() {
String structStr = this.struct.toString();
assertNotNull("Struct string should not be null.", structStr);
assertFalse("Struct string should not be empty.", structStr.isEmpty());
}

private Object roundtrip(Type type, Object obj) {
ByteBuffer buffer = ByteBuffer.allocate(type.sizeOf(obj));
type.write(buffer, obj);
Expand Down