HOTFIX: wrong keyvalue equals logic when keys not equal but values equal#1293
Closed
enothereska wants to merge 2 commits into
Closed
HOTFIX: wrong keyvalue equals logic when keys not equal but values equal#1293enothereska wants to merge 2 commits into
enothereska wants to merge 2 commits into
Conversation
Contributor
Author
|
@guozhangwang @ijuma @miguno could you please have a look. |
Contributor
|
Superceeded by #1294. This PR should not be merged. |
Contributor
|
@enothereska : Can you please close this PR? |
asfgit
pushed a commit
that referenced
this pull request
Apr 29, 2016
Fixes wrong KeyValue equals logic when keys not equal but values equal. Original hotfix PR at #1293 (/cc enothereska) Please review: ewencp ijuma guozhangwang Author: Eno Thereska <eno.thereska@gmail.com> Author: Michael G. Noll <michael@confluent.io> Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io> Closes #1294 from miguno/KeyValue-equality-hotfix
asfgit
pushed a commit
that referenced
this pull request
Apr 29, 2016
Fixes wrong KeyValue equals logic when keys not equal but values equal. Original hotfix PR at #1293 (/cc enothereska) Please review: ewencp ijuma guozhangwang Author: Eno Thereska <eno.thereska@gmail.com> Author: Michael G. Noll <michael@confluent.io> Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io> Closes #1294 from miguno/KeyValue-equality-hotfix (cherry picked from commit 60380e3) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Fixes wrong KeyValue equals logic when keys not equal but values equal. Original hotfix PR at apache#1293 (/cc enothereska) Please review: ewencp ijuma guozhangwang Author: Eno Thereska <eno.thereska@gmail.com> Author: Michael G. Noll <michael@confluent.io> Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#1294 from miguno/KeyValue-equality-hotfix
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
… a single WriteShareGroupState operation (apache#1293) * AKCORE-167-2: Minor bugfix, share state map was being updated twice for a single wrteShareGroupState operation * AKCORE-167-2: Renamed a variable and added javadocs in ShareCoordinatorShard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the previous logic, if key does NOT equal, but value DOES equal, then equals returns TRUE.