HOTFIX: Fix equality semantics of KeyValue#1294
Closed
miguno wants to merge 2 commits into
Closed
Conversation
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Apr 29, 2016
Fixes wrong KeyValue equals logic when keys not equal but values equal. Original hotfix PR at #1293 (/cc enothereska) Please review: ewencp ijuma guozhangwang Author: Eno Thereska <eno.thereska@gmail.com> Author: Michael G. Noll <michael@confluent.io> Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io> Closes #1294 from miguno/KeyValue-equality-hotfix (cherry picked from commit 60380e3) Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Fixes wrong KeyValue equals logic when keys not equal but values equal. Original hotfix PR at apache#1293 (/cc enothereska) Please review: ewencp ijuma guozhangwang Author: Eno Thereska <eno.thereska@gmail.com> Author: Michael G. Noll <michael@confluent.io> Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#1294 from miguno/KeyValue-equality-hotfix
efeg
added a commit
to efeg/kafka
that referenced
this pull request
May 29, 2024
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong KeyValue equals logic when keys not equal but values equal.
Original hotfix PR at #1293 (/cc @enothereska)
Please review: @ewencp @ijuma @guozhangwang