MINOR: Fix various memory leaks in tests#12959
Merged
cadonna merged 3 commits intoapache:trunkfrom Dec 21, 2022
Merged
Conversation
cadonna
reviewed
Dec 8, 2022
Member
There was a problem hiding this comment.
Why do you close the state store in the test here but not in the other tests?
Member
Author
There was a problem hiding this comment.
yeah, that's a duplicate
Comment on lines
152
to
154
Member
There was a problem hiding this comment.
I think it would be enough to just optionsFacadeDbOptions.close();. You already verify that optionsFacadeDbOptions.close(); calls mockedDbOptions.close(); in the try-block. No need to verify it again.
Alternatively, you could add close to the list of ignored methods (ignoreMethods) and verify as you did. However, you need to add verify(mockedDbOptions) after optionsFacadeDbOptions.close() otherwise nothing is verified.
Member
Author
There was a problem hiding this comment.
I'm just doing this so that easymock doesn't complain about close being called on the unterlying mock. I want to call close here to free up resources, and the best way here is to tell easymock what to expect on the mocks.
I found an alternative way to do this via resetToNice which should be less confusing.
Various tests in the streams park were leaking native memory. Most tests were fixed by closing the corresponding rocksdb resource.
…/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java Co-authored-by: Bruno Cadonna <cadonna@apache.org>
Member
|
Build failures are not related: |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
Various tests in the streams park were leaking native memory. Most tests were fixed by closing the corresponding rocksdb resource. I tested that the corresponding leak is gone by using a previous rocksdb release with finalizers and checking if the finalizers would be called at some point. Reviewer: Bruno Cadonna <cadonna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various tests in the streams park were leaking native memory.
Most tests were fixed by closing the corresponding rocksdb resource.
I tested that the corresponding leak is gone by using a previous rocksdb
release with finalizers and checking if the finalizers would be called at some
point.