KAFKA-14471: Move IndexEntry and related to storage module#12993
KAFKA-14471: Move IndexEntry and related to storage module#12993ijuma merged 1 commit intoapache:trunkfrom
Conversation
|
@dengziming do you happen to have cycles to review this PR? |
Sure, I have added it to my review backlog. |
dengziming
left a comment
dengziming
left a comment
There was a problem hiding this comment.
LGTM, the 2 comments are only trivial questions.
|
|
||
| package kafka.log | ||
|
|
||
| class CorruptIndexException(message: String) extends RuntimeException(message) |
There was a problem hiding this comment.
It's weird that git thinks CorruptIndexException is rename to IndexEntry.
There was a problem hiding this comment.
Yes, I agree. Not sure we can do anything about this though.
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
There was a problem hiding this comment.
Scala case class will generated same methods, right?
There was a problem hiding this comment.
Correct, case classes automatically generate toString, hashCode and equals and hence why I did the same here. However, the underlying implementation is not the same, but that's not an issue for us.
|
JDK 8 build passed while there was 1 unrelated failure for the each of the other JDKs:
Merging to trunk. |
For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module Reviewers: dengziming <dengziming1993@gmail.com>
…on` (apache#13008) apache#11390 and apache#12993 were merged in relatively quick succession, which resulted in compiler errors that weren't present when each change was on top of trunk. Reviewers: Mickael Maison <mickael.maison@gmail.com>
2 participants
For broader context on this change, please check:
Committer Checklist (excluded from commit message)