Skip to content

MINOR: Fix compiler errors in RemoteIndex* related to OffsetPosition#13008

Merged
mimaison merged 1 commit intoapache:trunkfrom
ijuma:fix-offset-entry-compile-error
Dec 17, 2022
Merged

MINOR: Fix compiler errors in RemoteIndex* related to OffsetPosition#13008
mimaison merged 1 commit intoapache:trunkfrom
ijuma:fix-offset-entry-compile-error

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Dec 17, 2022

#11390 and #12993 were merged in relatively quick succession, which
resulted in compiler errors that weren't present when each change was
on top of trunk.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma requested review from dengziming and showuon December 17, 2022 18:23
and that resulted in compiler errors that weren't present when
each change was on top of trunk.
@ijuma ijuma force-pushed the fix-offset-entry-compile-error branch from 95b55a9 to 28994a2 Compare December 17, 2022 18:24
@ijuma ijuma requested review from dajac and mimaison December 17, 2022 18:25
Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison mimaison merged commit 8d09fc9 into apache:trunk Dec 17, 2022
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Dec 17, 2022

Thanks for the quick review.

@ijuma ijuma deleted the fix-offset-entry-compile-error branch December 17, 2022 20:58
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
…on` (apache#13008)

apache#11390 and apache#12993 were merged in relatively quick succession, which resulted in compiler errors that weren't present when each change was on top of trunk.

Reviewers: Mickael Maison <mickael.maison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants