KAFKA-3728 EndToEndAuthorizationTest offsets_topic misconfigured#1425
Closed
edoardocomar wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-3728 EndToEndAuthorizationTest offsets_topic misconfigured#1425edoardocomar wants to merge 1 commit intoapache:trunkfrom
edoardocomar wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
Hi @ijuma I've implemented your suggestions. I got rid of the TopicAuthorizationException on __consumer_offsets but otherwise testProduceConsumeViaSubscribe fails if it's not the first one to be Disappointing, this may be a cleanup problem but I could not spot any. |
edoardocomar
force-pushed
the
KAFKA-3728
branch
2 times, most recently
from
6397dcf to
61f45ec
Compare
Member
|
@edoardocomar, sorry for the delay. I investigated the issue and I think #1455 should fix it (I briefly tested your PR with it). |
Contributor
Author
|
thanks @ijuma does this mean that I should be able to get rid of |
Member
|
Yes. |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2016
I found both issues while investigating the issue described in PR #1425. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Jun Rao <junrao@gmail.com> Closes #1455 from ijuma/fix-integration-test-harness-and-zk-test-harness (cherry picked from commit 1029030) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Member
|
@edoardocomar, can you please rebase this now that #1455 was merged? |
Member
There was a problem hiding this comment.
Maybe call this setAclsAndProduce()
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
I found both issues while investigating the issue described in PR apache#1425. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Jun Rao <junrao@gmail.com> Closes apache#1455 from ijuma/fix-integration-test-harness-and-zk-test-harness
Set OffsetsTopicReplicationFactorProp to 3 like MinInSyncReplicasProp Else a consumer was able to consume via assign but not via subscribe, so the testProduceAndConsume is now duplicated to check both paths
Contributor
Author
Member
|
LGTM @edoardocomar. Can you please update the PR description to match the commit message? The PR message is what gets used by our PR merge script in the merge commit. I'll merge it to trunk and 0.10.0 once you do that and the tests pass. Merging to 0.10.0 to make it easier to backport KAFKA-3396. |
edoardocomar
changed the title
edoardocomar
changed the title
Contributor
Author
|
Hi @ijuma all the tests pass for me - unlike in the Jenkins build. How do I re-kick a Jenkins build? |
Member
|
I'll run the tests locally. Can you please not repeat the PR title in the description? |
Contributor
Author
|
done thx |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2016
Set OffsetsTopicReplicationFactorProp to 3 like MinInSyncReplicasProp Else a consumer was able to consume via assign but not via subscribe, so the testProduceAndConsume is now duplicated to check both paths Author: Edoardo Comar <ecomar@uk.ibm.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #1425 from edoardocomar/KAFKA-3728 (cherry picked from commit 49ddc89) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
granthenke
pushed a commit
to granthenke/kafka
that referenced
this pull request
Oct 24, 2016
I found both issues while investigating the issue described in PR apache#1425. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Jun Rao <junrao@gmail.com> Closes apache#1455 from ijuma/fix-integration-test-harness-and-zk-test-harness (cherry picked from commit 1029030) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
granthenke
pushed a commit
to granthenke/kafka
that referenced
this pull request
Oct 24, 2016
Set OffsetsTopicReplicationFactorProp to 3 like MinInSyncReplicasProp Else a consumer was able to consume via assign but not via subscribe, so the testProduceAndConsume is now duplicated to check both paths Author: Edoardo Comar <ecomar@uk.ibm.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#1425 from edoardocomar/KAFKA-3728 (cherry picked from commit 49ddc89) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set OffsetsTopicReplicationFactorProp to 3 like MinInSyncReplicasProp Else a consumer was able to consume via assign but not via subscribe, so the testProduceAndConsume is now duplicated to check both paths