MINOR: Fix setting of ACLs and ZK shutdown in test harnesses#1455
Closed
ijuma wants to merge 2 commits intoapache:trunkfrom
Closed
MINOR: Fix setting of ACLs and ZK shutdown in test harnesses#1455ijuma wants to merge 2 commits intoapache:trunkfrom
ijuma wants to merge 2 commits intoapache:trunkfrom
Conversation
Member
Author
|
+1 |
ijuma
force-pushed
the
fix-integration-test-harness-and-zk-test-harness
branch
from
1bb58c1 to
961b7f1
Compare
And call the latter before servers start instead of after.
ijuma
force-pushed
the
fix-integration-test-harness-and-zk-test-harness
branch
from
961b7f1 to
5dec704
Compare
| CoreUtils.swallow(zookeeper.shutdown()) | ||
| CoreUtils.swallow(factory.shutdown()) | ||
|
|
||
| def isDown(): Boolean = { |
Contributor
There was a problem hiding this comment.
There are a few tests that only extend ZooKeeperTestHarness. Do we need to ensure that ZK is down when shutting down ZooKeeperTestHarness?
Member
Author
There was a problem hiding this comment.
ZooKeeperTestHarness.tearDown calls this method:
if (zookeeper != null)
CoreUtils.swallow(zookeeper.shutdown())Isn't that good enough?
Contributor
There was a problem hiding this comment.
Yes, you are right. The code looks good then.
Contributor
|
Thanks for the patch. LGTM. Just left a minor comment. |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2016
I found both issues while investigating the issue described in PR #1425. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Jun Rao <junrao@gmail.com> Closes #1455 from ijuma/fix-integration-test-harness-and-zk-test-harness (cherry picked from commit 1029030) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
Member
Author
|
Thank you for the reviews, merged to trunk and 0.10.0 branches (KAFKA-3396 which would be good to backport requires these changes for the tests to work). |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
I found both issues while investigating the issue described in PR apache#1425. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Jun Rao <junrao@gmail.com> Closes apache#1455 from ijuma/fix-integration-test-harness-and-zk-test-harness
granthenke
pushed a commit
to granthenke/kafka
that referenced
this pull request
Oct 24, 2016
I found both issues while investigating the issue described in PR apache#1425. Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Jun Rao <junrao@gmail.com> Closes apache#1455 from ijuma/fix-integration-test-harness-and-zk-test-harness (cherry picked from commit 1029030) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found both issues while investigating the issue described in PR #1425.