MINOR: ConsumerRebalanceListenerInvoker class and method visibility#14931
Merged
dajac merged 1 commit intoapache:trunkfrom Dec 6, 2023
kirktrue:MINOR-consumer-rebalance-listener-visibility-and-logging-changes
Merged
MINOR: ConsumerRebalanceListenerInvoker class and method visibility#14931dajac merged 1 commit intoapache:trunkfrom kirktrue:MINOR-consumer-rebalance-listener-visibility-and-logging-changes
dajac merged 1 commit intoapache:trunkfrom
kirktrue:MINOR-consumer-rebalance-listener-visibility-and-logging-changes
Conversation
For forthcoming changes, make this class and its method public for use outside the package. Also fix a minor logging issue to include the object in the log, not its Optional wrapper.
Contributor
Author
Contributor
Author
|
@philipnee can you add the |
dajac
added
KIP-848
Contributor
Author
|
Three yellows, one red. Restarting 🤞 |
Contributor
Author
|
Four greys. Restarting build again. |
Contributor
Author
|
@dajac—failing tests appear unrelated. Do we need four green builds before merging? |
gaurav-narula
pushed a commit
to gaurav-narula/kafka
that referenced
this pull request
Jan 24, 2024
…pache#14931) For forthcoming changes, make this class and its methods public for use outside the package. Also fix a minor logging issue to include the object in the log, not its `Optional` wrapper. Reviewers: David Jacot <djacot@confluent.io>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…pache#14931) For forthcoming changes, make this class and its methods public for use outside the package. Also fix a minor logging issue to include the object in the log, not its `Optional` wrapper. Reviewers: David Jacot <djacot@confluent.io>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…pache#14931) For forthcoming changes, make this class and its methods public for use outside the package. Also fix a minor logging issue to include the object in the log, not its `Optional` wrapper. Reviewers: David Jacot <djacot@confluent.io>
kirktrue
deleted the
MINOR-consumer-rebalance-listener-visibility-and-logging-changes
branch
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…pache#14931) For forthcoming changes, make this class and its methods public for use outside the package. Also fix a minor logging issue to include the object in the log, not its `Optional` wrapper. Reviewers: David Jacot <djacot@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For forthcoming changes, make this class and its methods public for use outside the package. Also fix a minor logging issue to include the object in the log, not its
Optionalwrapper.