MINOR: fix LogValidatorTest#checkNonCompressed#15904
Merged
chia7712 merged 5 commits intoapache:trunkfrom May 11, 2024
Merged
Conversation
3 tasks
junrao
reviewed
May 9, 2024
Member
Author
|
@junrao thanks for reviewing this rough patch :( |
Member
Author
Member
Author
|
|
|
||
| // Both V2 and V1 has single branch in the record when compression is enable, and hence their shallow OffsetOfMaxTimestamp | ||
| // is the last offset of the single branch | ||
| assertEquals(1, records.batches().asScala.size) |
Contributor
There was a problem hiding this comment.
If I understand this test case correctly, there might still be a minor issue with "checkRecompression":
- at line 455,
recordsshould be created with "CompressionType.NONE". - at line 502, the check should be
assertEquals(1, validatedRecords.batches().asScala.size)
Contributor
There was a problem hiding this comment.
@vincent81jiang : Thanks for the comment. The line at 455 seems to be wrong. What do you think @chia7712 ?
Member
Author
There was a problem hiding this comment.
@vincent81jiang you are totally right. I have filed PR (#15948) to fix that
3 tasks
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Reviewers: Jun Rao <junrao@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from: #15621 (comment)
This is a follow-up of #15621
Committer Checklist (excluded from commit message)