Skip to content

MINOR: revisit LogValidatorTest#checkRecompression#15948

Merged
chia7712 merged 3 commits intoapache:trunkfrom
chia7712:MINOR-15948
May 15, 2024
Merged

MINOR: revisit LogValidatorTest#checkRecompression#15948
chia7712 merged 3 commits intoapache:trunkfrom
chia7712:MINOR-15948

Conversation

@chia7712
Copy link
Copy Markdown
Member

from #15904 (comment)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712
Copy link
Copy Markdown
Member Author

ping @junrao @vincent81jiang

Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 : Thanks for the PR. Just a couple of minor comments.

Comment thread core/src/test/scala/unit/kafka/log/LogValidatorTest.scala Outdated
Comment thread core/src/test/scala/unit/kafka/log/LogValidatorTest.scala Outdated
@chia7712
Copy link
Copy Markdown
Member Author

@junrao thanks for all your reviews :)

Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 : Thanks for the updated PR. LGTM.

The test failures seem unrelated, but it would be useful to file jiras for the untracked ones.

@chia7712
Copy link
Copy Markdown
Member Author

test jira
testDelayedConfigurationOperations https://issues.apache.org/jira/browse/KAFKA-16773
testOffsetTranslationBehindReplicationFlow https://issues.apache.org/jira/browse/KAFKA-15197
testAlterSinkConnectorOffsets https://issues.apache.org/jira/browse/KAFKA-15892
testElectPreferredLeaders https://issues.apache.org/jira/browse/KAFKA-8458
testSeparateOffsetsTopic https://issues.apache.org/jira/browse/KAFKA-14089
testNoConsumeWithoutDescribeAclViaSubscribe https://issues.apache.org/jira/browse/KAFKA-9655
testNoConsumeWithDescribeAclViaSubscribe https://issues.apache.org/jira/browse/KAFKA-7646
testCreateUserWithDelegationToken https://issues.apache.org/jira/browse/KAFKA-16501
testDescribeTokenForOtherUserFails https://issues.apache.org/jira/browse/KAFKA-15411
testCoordinatorFailover https://issues.apache.org/jira/browse/KAFKA-16024
shouldWorkWithUncleanShutdownWipeOutStateStore https://issues.apache.org/jira/browse/KAFKA-16502
shouldCloseAllTaskProducersOnCloseIfEosEnabled https://issues.apache.org/jira/browse/KAFKA-16774
testTaskRequestWithOldStartMsGetsUpdated https://issues.apache.org/jira/browse/KAFKA-8115
testSyncTopicConfigs https://issues.apache.org/jira/browse/KAFKA-14453
testReplicateSourceDefault https://issues.apache.org/jira/browse/KAFKA-15292
testCreateTokenForOtherUserFails https://issues.apache.org/jira/browse/KAFKA-15411
testDescribeTokenForOtherUserFails https://issues.apache.org/jira/browse/KAFKA-15411
testCreateExistingTopicsThrowTopicExistsException https://issues.apache.org/jira/browse/KAFKA-16775
testLowMaxFetchSizeForRequestAndPartition https://issues.apache.org/jira/browse/KAFKA-16494
testTaskRequestWithOldStartMsGetsUpdated https://issues.apache.org/jira/browse/KAFKA-8115

@chia7712 chia7712 merged commit aca5d24 into apache:trunk May 15, 2024
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
@chia7712 chia7712 deleted the MINOR-15948 branch September 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants