Skip to content

KAFKA-17834 Improvement the Dockerfile#17554

Merged
mimaison merged 10 commits intoapache:trunkfrom
m1a2st:KAFKA-17834
Sep 22, 2025
Merged

KAFKA-17834 Improvement the Dockerfile#17554
mimaison merged 10 commits intoapache:trunkfrom
m1a2st:KAFKA-17834

Conversation

@m1a2st
Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st commented Oct 19, 2024

Jira: https://issues.apache.org/jira/browse/KAFKA-17834

This PR fixed thress dockerfile warning:

  1. MaintainerDeprecated
  2. LegacyKeyValueFormat
  3. JSONArgsRecommended

If have any warning, It will show in console like CleanShot 2024-10-19 at 23 59 02@2x

I ran on my local machine: It won't show any warning CleanShot 2024-10-19 at 23 58 06@2x

The e2e test also can run and pass CleanShot 2024-10-20 at 00 16 36@2x

@github-actions github-actions Bot added tests Test fixes (including flaky tests) small Small PRs labels Oct 19, 2024
@chia7712
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m1a2st thanks for this improvement!

Comment thread tests/docker/Dockerfile

USER ducker

CMD sudo service ssh start && tail -f /dev/null
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use the tail to make the container alive, and that can be replaced by detaching the sshd. Hence, could you please try to use CMD ["sudo", "service", "ssh", "start", "-D"] instaead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can pass on my local
image

@chia7712
Copy link
Copy Markdown
Member

@m1a2st Could you please rebase code?

@github-actions github-actions Bot added the docker Official Docker image label Jan 12, 2025
@m1a2st m1a2st changed the title KAFKA-17834 Improvement the e2e Dockerfile KAFKA-17834 Improvement the Dockerfile Jan 12, 2025
Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison
Copy link
Copy Markdown
Member

mimaison commented Sep 3, 2025

@chia7712 Did you have other comments?

@mimaison mimaison merged commit da6a562 into apache:trunk Sep 22, 2025
22 of 23 checks passed
jim0987795064 pushed a commit to jim0987795064/kafka that referenced this pull request Sep 25, 2025
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
shashankhs11 pushed a commit to shashankhs11/kafka that referenced this pull request Dec 15, 2025
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
gaurav-narula pushed a commit to gaurav-narula/kafka that referenced this pull request Apr 2, 2026
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
fvaleri pushed a commit to fvaleri/kafka that referenced this pull request Apr 7, 2026
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved docker Official Docker image small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants