KAFKA-18340 Change Dockerfile to use log4j2 yaml instead log4j properties#18378
Merged
mimaison merged 3 commits intoapache:trunkfrom Jan 10, 2025
Merged
KAFKA-18340 Change Dockerfile to use log4j2 yaml instead log4j properties#18378mimaison merged 3 commits intoapache:trunkfrom
mimaison merged 3 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
mimaison
reviewed
Jan 9, 2025
| org.label-schema.description="Apache Kafka" \ | ||
| org.label-schema.build-date="${build_date}" \ | ||
| org.label-schema.vcs-url="https://github.com/apache/kafka" \ | ||
| maintainer="Apache Kafka" |
Member
There was a problem hiding this comment.
Why are we making this change? If there's a rational for making it, I'd rather do it in a separate PR instead.
Collaborator
Author
There was a problem hiding this comment.
I should revert it, the MAINTAINER is deprecated
doc
Member
There was a problem hiding this comment.
Thanks for the explanation. Let's fix that in another PR.
Collaborator
Author
There was a problem hiding this comment.
sure, I will address in another PR
Collaborator
Author
mimaison
pushed a commit
that referenced
this pull request
Jan 10, 2025
…rties (#18378) Reviewers: Mickael Maison <mickael.maison@gmail.com>
Member
|
Applied to 4.0 too: 5e6f200 |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 10, 2025
…emove-metadata-version-methods-for-versions-older-than-3.0 * apache-github/trunk: KAFKA-18340: Change Dockerfile to use log4j2 yaml instead log4j properties (apache#18378) MINOR: fix flaky RemoteLogManagerTest#testStopPartitionsWithDeletion (apache#18474) KAFKA-18311: Enforcing copartitioned topics (4/N) (apache#18397) KAFKA-18308; Update CoordinatorSerde (apache#18455) KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (apache#18435) KAFKA-17671: Create better documentation for transactions (apache#17454) KAFKA-18304; Introduce json converter generator (apache#18458) MINOR: Clean up classic group tests (apache#18473) KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN and ENVELOPE (apache#18422) MINOR: improve StreamThread periodic processing log (apache#18430)
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…rties (apache#18378) Reviewers: Mickael Maison <mickael.maison@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…rties (apache#18378) Reviewers: Mickael Maison <mickael.maison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18340
We already upgrade log4j to log4j2, we should update our docker image to use log4j2 yaml file
Committer Checklist (excluded from commit message)