Skip to content

KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN , ENVELOPE#18422

Merged
chia7712 merged 3 commits intoapache:trunkfrom
TaiJuWu:rm_zk-1
Jan 9, 2025
Merged

KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN , ENVELOPE#18422
chia7712 merged 3 commits intoapache:trunkfrom
TaiJuWu:rm_zk-1

Conversation

@TaiJuWu
Copy link
Copy Markdown
Collaborator

@TaiJuWu TaiJuWu commented Jan 7, 2025

KRaft mode does not support follow RPC and this PR would remove them.

  • case ApiKeys.CONTROLLED_SHUTDOWN => handleControlledShutdownRequest(request)
  • case ApiKeys.ENVELOPE => handleEnvelope(request, requestLocal)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions Bot added triage PRs from the community core Kafka Broker labels Jan 7, 2025
@TaiJuWu TaiJuWu marked this pull request as ready for review January 7, 2025 18:18
@TaiJuWu TaiJuWu changed the title KAFKA-18399 Remove ZooKeeper from KafkaApis (part 2) KAFKA-18399 Remove ZooKeeper from KafkaApis (part 2): LEADER_AND_ISR, STOP_REPLICA, UPDATE_METADATA, CONTROLLED_SHUTDOWN , ENVELOPE Jan 7, 2025
case ApiKeys.ALTER_USER_SCRAM_CREDENTIALS => maybeForwardToController(request, handleAlterUserScramCredentialsRequest)
case ApiKeys.ALTER_PARTITION => handleAlterPartitionRequest(request)
case ApiKeys.UPDATE_FEATURES => maybeForwardToController(request, handleUpdateFeatures)
case ApiKeys.ENVELOPE => handleEnvelope(request, requestLocal)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me using KafkaApis.shouldNeverReceive(request) is more readable.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for review.

@TaiJuWu TaiJuWu changed the title KAFKA-18399 Remove ZooKeeper from KafkaApis (part 2): LEADER_AND_ISR, STOP_REPLICA, UPDATE_METADATA, CONTROLLED_SHUTDOWN , ENVELOPE KAFKA-18399 Remove ZooKeeper from KafkaApis (part 2): CONTROLLED_SHUTDOWN , ENVELOPE Jan 8, 2025
@github-actions github-actions Bot removed the triage PRs from the community label Jan 9, 2025
@TaiJuWu TaiJuWu changed the title KAFKA-18399 Remove ZooKeeper from KafkaApis (part 2): CONTROLLED_SHUTDOWN , ENVELOPE KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN , ENVELOPE Jan 9, 2025
Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Jan 9, 2025

discussed with @m1a2st, @TaiJuWu could you please remove the unreachable path directly?

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Jan 9, 2025

@TaiJuWu please fix conflicts

@TaiJuWu
Copy link
Copy Markdown
Collaborator Author

TaiJuWu commented Jan 9, 2025

@TaiJuWu please fix conflicts

Done. PTAL.

Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Jan 9, 2025

failed test is traced by https://issues.apache.org/jira/browse/KAFKA-15474

@chia7712 chia7712 merged commit 5684fc7 into apache:trunk Jan 9, 2025
chia7712 pushed a commit that referenced this pull request Jan 9, 2025
…N and ENVELOPE (#18422)

Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
@TaiJuWu TaiJuWu deleted the rm_zk-1 branch January 10, 2025 02:21
m1a2st pushed a commit to m1a2st/kafka that referenced this pull request Jan 10, 2025
…N and ENVELOPE (apache#18422)

Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
ijuma added a commit to ijuma/kafka that referenced this pull request Jan 10, 2025
…emove-metadata-version-methods-for-versions-older-than-3.0

* apache-github/trunk:
  KAFKA-18340: Change Dockerfile to use log4j2 yaml instead log4j properties (apache#18378)
  MINOR: fix flaky RemoteLogManagerTest#testStopPartitionsWithDeletion (apache#18474)
  KAFKA-18311: Enforcing copartitioned topics (4/N) (apache#18397)
  KAFKA-18308; Update CoordinatorSerde (apache#18455)
  KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (apache#18435)
  KAFKA-17671: Create better documentation for transactions (apache#17454)
  KAFKA-18304; Introduce json converter generator (apache#18458)
  MINOR: Clean up classic group tests (apache#18473)
  KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN and ENVELOPE (apache#18422)
  MINOR: improve StreamThread periodic processing log (apache#18430)
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
…N and ENVELOPE (apache#18422)

Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
…N and ENVELOPE (apache#18422)

Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants