KAFKA-18419: KIP-891 Connect Multiversion Support (Transformation and Predicate Changes)#17742
Merged
gharris1727 merged 147 commits intoapache:trunkfrom Jan 6, 2025
Merged
Conversation
gharris1727
reviewed
Dec 13, 2024
Contributor
gharris1727
left a comment
gharris1727
left a comment
There was a problem hiding this comment.
I don't see anything that stands out to me right now. Once the build is fixed i think we can merge.
Contributor
Author
|
Hi @gharris1727. I have updated the code a bit. PTAL and LMK if you have any queries. |
gharris1727
reviewed
Dec 17, 2024
| // The value will be null if the class couldn't be found; no point in performing follow-up validation | ||
| if (value != null) { | ||
| getConfigDefFromConfigProvidingClass(typeConfig, (Class<?>) value); | ||
| getConfigDefFromPlugin(typeConfig, ((Class<?>) value).getName(), null, plugins); |
Contributor
There was a problem hiding this comment.
I think this validator needs to include the error when the version is incorrect, similar to the converters.
Contributor
Author
|
Updated the code to include the latest suggestion. The failed test looks unrelated. |
This was referenced Dec 27, 2024
Contributor
Author
|
Hi @gharris1727, please follow up on this review and the subsequent ones for multiversioning. |
gharris1727
approved these changes
Jan 6, 2025
Contributor
gharris1727
left a comment
gharris1727
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
gharris1727
changed the title
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
… Predicate Changes) (apache#17742) Reviewers: Greg Harris <greg.harris@aiven.io>
gharris1727
pushed a commit
that referenced
this pull request
Jun 5, 2025
…ion Tests (#18325) This adds tests for [KIP-891](https://cwiki.apache.org/confluence/display/KAFKA/KIP-891%3A+Running+multiple+versions+of+Connector+plugins). It primarily focuses on tests for the new additions in plugin loading isolation. It has dependency on the actual KIP implementation PRs and should be merged post #17742 Reviewers: Greg Harris <greg.harris@aiven.io>
Mirai1129
pushed a commit
to Mirai1129/kafka
that referenced
this pull request
Jun 5, 2025
…ion Tests (apache#18325) This adds tests for [KIP-891](https://cwiki.apache.org/confluence/display/KAFKA/KIP-891%3A+Running+multiple+versions+of+Connector+plugins). It primarily focuses on tests for the new additions in plugin loading isolation. It has dependency on the actual KIP implementation PRs and should be merged post apache#17742 Reviewers: Greg Harris <greg.harris@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The is one of a set of PRs for KIP-891. The list of total PRs given below all build one the previous one in the list. They can be reviewed individually, or if the complete set of changes is preferrable, please refer to the last PR.
This is PR#3 and contains changes to support multiple versions of transformation and predicates with appropriate defaults and validations.
Committer Checklist (excluded from commit message)