KAFKA-17705: Add Transactions V2 system tests and mark as production ready by jolshan · Pull Request #18132 · apache/kafka

jolshan · 2024-12-10T23:21:34Z

Added transaction version 2 to some of the system tests. Also marking TV2 as production ready.
Will share the results of the tests when I get them.

mumrah · 2024-12-11T13:12:49Z

@jolshan #17881 adds a "triage" label to PRs from non-committers. Turns out this also affect committers if their membership visibility in the ASF GitHub org is not public. I added instructions for setting your membership visibility to public https://github.com/apache/kafka/blob/trunk/.github/workflows/README.md#pr-triage

jolshan · 2024-12-11T18:53:15Z

                    MetadataVersion.latestProduction().featureLevel()));
        for (Feature feature : Feature.PRODUCTION_FEATURES) {
-            short maxVersion = enableUnstable ? feature.latestTesting() : feature.latestProduction();
+            short maxVersion = enableUnstable ? feature.latestTesting() : feature.defaultLevel(MetadataVersion.LATEST_PRODUCTION);


@junrao @dongnuo123 I noticed we didn't change the defaults here on the previous PR. I have done so here. A test was failing since the production version for transaction version is now not the same as the default based on the latest production MV.

@jolshan : Not sure that I understand this change. The result of defaultFeatureMap is used for Controller/Broker registration. So, it seems that we should pass in the max supported version of each feature, instead of the default version, right? In fact, defaultFeatureMap should be renamed to sth like supportedFeatureMap.

A test was failing since the production version for transaction version is now not the same as the default based on the latest production MV.

Hmm, I thought that with #17886, it's ok for the latest production version for TV to be different from the default. It just needs to be larger.

Yes. My understanding from #17886 was that we want a separate production vs default value.

I thought these methods were also meant to create the default features, not the max supported ones. It's my bad if I misunderstood that. I will take another look and if that is the case, fix the test.

Updated with the changes to the name and the test

junrao

@jolshan : Thanks for the updated PR. Just a minor comment.

junrao · 2024-12-11T22:44:33Z

        latestFinalizedFeaturesEpoch = info.finalizedFeaturesEpoch;
        Short transactionVersion = info.finalizedFeatures.get("transaction.version");
        isTransactionV2Enabled = transactionVersion != null && transactionVersion >= 2;
+        log.debug("Updating isTV2 enabled to {} at with FinalizedFeaturesEpoch {}", isTransactionV2Enabled, latestFinalizedFeaturesEpoch);


at with FinalizedFeaturesEpoch => with FinalizedFeaturesEpoch

oops. good catch :)

jolshan · 2024-12-11T23:15:45Z

I am seeing some test failures in the system tests, so I will investigate.
Just the new tests: https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-12-11--001.9f140bcb-58de-4f2e-86da-3aae08f7a620--1733958321--jolshan--kafka-17705--e69893c32c/report.html

some issues with the old tests: https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-12-11--001.600822cf-da88-4744-b834-795c565d98d5--1733957556--jolshan--kafka-17705--e69893c32c/report.html (some could be already failing on trunk)

jolshan · 2024-12-12T01:46:31Z

Here's a trunk run. https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-12-11--001.fef0e933-9fb0-477e-aa78-bfc923367dd0--1733964566--apache--trunk--d83f09d014/report.html

I also pushed a change and started a new test specific run.

junrao

@jolshan : Thanks for the updated PR. Is the unit test failure related? Also, it seems that a bunch of system tests timed out.

jolshan · 2024-12-12T17:55:05Z

Thanks Jun. Taking a look.

jolshan · 2024-12-12T17:56:48Z

Here's the new run of just the changed tests: https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-12-12--001.65845de4-1d44-4e7d-8d23-ac15c9440cb2--1733986841--jolshan--kafka-17705--92dfdf6028/report.html

Still is a bit flaky even with the timeout increased. Will look at that. I also need to see if the consumer failures are unique to this PR or something that was in trunk at the time I branched.

jolshan · 2024-12-12T17:58:35Z

The unit test failure does not seem related.

jolshan · 2024-12-12T19:15:12Z

This explains the main divergence from trunk failures #18036. I do see some issues with fencing in the changes to the tests, so I will continue to investigate

jolshan · 2024-12-13T00:24:47Z

System tests uncovered a bug! Will fix that and come back here :) https://issues.apache.org/jira/browse/KAFKA-18227

jolshan · 2024-12-19T00:19:33Z

I've merged #18176, so I will update this now and rerun tests.

junrao · 2024-12-19T21:55:11Z

@jolshan : Thanks for rerunning the tests. Is the build scan failure related to this PR?

jolshan · 2024-12-20T22:22:15Z

@junrao nope -- I confirmed with David Arthur that the build scan issue for quarantined tests is unrelated.

Here are the latest test results (without the log4j change that seems to be causing issues for our test running infra)
https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-12-20--001.06d0f058-3bac-4707-89dd-16e641f2bd13--1734724283--jolshan--testing-17705-2--2f7729dfca/report.html

junrao

@jolshan : Thanks for looking into the test failure. The PR LGTM.

…ready (#18132) Added transaction version 2 to some of the system tests. Also marking TV2 as production ready. Also fixes the defaultVersion test. Reviewers: Jun Rao <jun@confluent.io>

…ready (apache#18132) Added transaction version 2 to some of the system tests. Also marking TV2 as production ready. Also fixes the defaultVersion test. Reviewers: Jun Rao <jun@confluent.io>

chia7712 · 2025-12-14T15:36:25Z

                        cmd += " --standalone"
                        self.standalone_controller_bootstrapped = True
+            if self.use_transactions_v2:
+                cmd += " --feature transaction.version=2"


We missed setting transaction.version for isolated kraft, resulting in the cluster using v0. Since this nullifies the suit use_transactions_v2=True, we will submit a patch later.

Hmm, is there a separate place to see this? That is unfortunate.

I observed this issue while running tests/kafkatest/tests/core/transactions_test.py

The settings "isolated_kraft" and "use_transactions_v2=true" failed to enable tv2 on the cluster

Do we know how this maps to the kafka.py file? Ie, why this line of code doesn't apply for isolated kraft?

Do we know how this maps to the kafka.py file? Ie, why this line of code doesn't apply for isolated kraft?

see #21164

Add tests and mark tv2 as production ready

cea8fe2

github-actions bot added triage PRs from the community core Kafka Broker producer clients small Small PRs labels Dec 10, 2024

typos

d15a964

jolshan force-pushed the kafka-17705 branch from eee2d0b to d15a964 Compare December 11, 2024 00:27

mumrah removed the triage PRs from the community label Dec 11, 2024

jolshan added 2 commits December 11, 2024 08:38

Other fixes

e69893c

Fix default version

978c49b

github-actions bot added the kraft label Dec 11, 2024

jolshan commented Dec 11, 2024

View reviewed changes

Fix naming,tests for defaultFeature map

fdcfaa3

github-actions bot removed the small Small PRs label Dec 11, 2024

junrao reviewed Dec 11, 2024

View reviewed changes

Update test and log message

92dfdf6

junrao reviewed Dec 12, 2024

View reviewed changes

Merge branch 'trunk' of github.com:apache/kafka into kafka-17705

2496a60

junrao approved these changes Dec 21, 2024

View reviewed changes

jolshan merged commit 8bd3746 into apache:trunk Dec 21, 2024

chia7712 reviewed Dec 14, 2025

View reviewed changes

Conversation

jolshan commented Dec 10, 2024

Uh oh!

mumrah commented Dec 11, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junrao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jolshan commented Dec 11, 2024

Uh oh!

jolshan commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junrao left a comment

Choose a reason for hiding this comment

Uh oh!

jolshan commented Dec 12, 2024

Uh oh!

jolshan commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jolshan commented Dec 12, 2024

Uh oh!

jolshan commented Dec 12, 2024

Uh oh!

jolshan commented Dec 13, 2024

Uh oh!

jolshan commented Dec 19, 2024

Uh oh!

junrao commented Dec 19, 2024

Uh oh!

jolshan commented Dec 20, 2024

Uh oh!

junrao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jolshan commented Dec 12, 2024 •

edited

Loading

jolshan commented Dec 12, 2024 •

edited

Loading