Skip to content

MINOR: Fix use_transactions_v2 usage in e2e#21164

Merged
chia7712 merged 2 commits intoapache:trunkfrom
mingyen066:MINOR-Fix-use_transaction_v2-usage-in-e2e
Dec 24, 2025
Merged

MINOR: Fix use_transactions_v2 usage in e2e#21164
chia7712 merged 2 commits intoapache:trunkfrom
mingyen066:MINOR-Fix-use_transaction_v2-usage-in-e2e

Conversation

@mingyen066
Copy link
Copy Markdown
Collaborator

@mingyen066 mingyen066 commented Dec 16, 2025

The use_transaction_v2 should be passed to controller node in isolated
controller. Otherwise, the transaction v2 won't be enabled.

Reviewers: Justine Olshan jolshan@confluent.io, Andrew Schofield
aschofield@confluent.io, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) small Small PRs labels Dec 16, 2025
@mingyen066 mingyen066 changed the title MINOR: Fix use_transaction_v2 usage in e2e MINOR: [DRAFT] Fix use_transaction_v2 usage in e2e Dec 16, 2025
@chia7712 chia7712 changed the title MINOR: [DRAFT] Fix use_transaction_v2 usage in e2e MINOR: Fix use_transactions_v2 usage in e2e Dec 19, 2025
Comment thread tests/kafkatest/services/kafka/kafka.py Outdated
@github-actions github-actions bot removed the triage PRs from the community label Dec 20, 2025
@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Dec 20, 2025

Here is the output (TransactionalMessageCopier) from the command:

TC_PATHS="tests/kafkatest/tests/core/transactions_test.py::TransactionsTest.test_transactions" \
_DUCKTAPE_OPTIONS='--parameters '\''{"failure_mode":"hard_bounce","bounce_target":"brokers","check_order":"True","use_group_metadata":"True","metadata_quorum":"ISOLATED_KRAFT","group_protocol":"classic","use_transactions_v2":"True"}'\'  \
/bin/bash tests/docker/run_tests.sh

before

[2025-12-20 04:14:05,065] DEBUG [Producer clientId=producer-copier-0, transactionalId=copier-0] Updating isTV2 enabled to false with FinalizedFeaturesEpoch 353 (org.apache.kafka.clients.producer.internals.TransactionManager)

after

[2025-12-19 18:00:57,151] DEBUG [Producer clientId=producer-copier-0, transactionalId=copier-0] Updating isTV2 enabled to true with FinalizedFeaturesEpoch 286 (org.apache.kafka.clients.producer.internals.TransactionManager)

@chia7712
Copy link
Copy Markdown
Member

I ran the transactions_upgrade_test.py and transactions_test.py with this patch and the fix from #21176, and they all passed

@chia7712 chia7712 merged commit a37e79a into apache:trunk Dec 24, 2025
26 checks passed
@mingyen066 mingyen066 deleted the MINOR-Fix-use_transaction_v2-usage-in-e2e branch February 13, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants