Skip to content

KAFKA-15474: Disable flaky testWakeupAfterSyncGroupReceivedExternalCompletion#18188

Merged
chia7712 merged 1 commit intoapache:trunkfrom
frankvicky:KAFKA-15474
Dec 15, 2024
Merged

KAFKA-15474: Disable flaky testWakeupAfterSyncGroupReceivedExternalCompletion#18188
chia7712 merged 1 commit intoapache:trunkfrom
frankvicky:KAFKA-15474

Conversation

@frankvicky
Copy link
Copy Markdown
Contributor

JIRA: KAFKA-15474

as title, since test-common:test-common-api requires Java 17, we use @Disable instead.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions Bot added triage PRs from the community consumer tests Test fixes (including flaky tests) clients small Small PRs labels Dec 15, 2024
@chia7712 chia7712 changed the title KAFKA-15474: Disable flaky test KAFKA-15474: Disable flaky testWakeupAfterSyncGroupReceivedExternalCompletion Dec 15, 2024
@chia7712 chia7712 merged commit 0781b1b into apache:trunk Dec 15, 2024
@mumrah
Copy link
Copy Markdown
Member

mumrah commented Dec 18, 2024

Should we have marked this test as flaky instead of disabling it? E.g., @Tag("flaky")

@chia7712
Copy link
Copy Markdown
Member

Should we have marked this test as flaky instead of disabling it? E.g., @tag("flaky")

You are right - it is always better to have more Gradle report.

@frankvicky could you please file a minor to address it? BTW, please keep the jira reference

@chia7712
Copy link
Copy Markdown
Member

oh, you have filed the PR #18263

@github-actions github-actions Bot removed the triage PRs from the community label Dec 19, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
…pletion (apache#18188)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved clients consumer small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants