Conversation
github-actions
Bot
added
core
|
cc @jolshan and @AndrewJSchofield -- thanks for filing the JIRAs. cc @frankvicky and @chia7712 -- WDYT about re-enabling testWakeupAfterSyncGroupReceivedExternalCompletion in the flaky suite? |
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Approved for the AbstractCoordinatorTest tagging.
| awaitFirstHeartbeat(heartbeatReceived); | ||
| } | ||
|
|
||
| @Tag("flaky") // "KAFKA-18310" |
There was a problem hiding this comment.
Ah, I was wondering how to do that because @Flaky wasn't doing the job.
There was a problem hiding this comment.
Maybe we should disallow "disabled" flag by import control due to quarantine mechanism.
| } | ||
| } | ||
|
|
||
| @Flaky("KAFKA-18306") |
There was a problem hiding this comment.
I have the PR open for this -- #18264, so do we still want to mark it?
As an aside, what is the process for removing the tag? I removed the others in my PR but didn't know if there was a time we wanted to analyze the new results before removing.
There was a problem hiding this comment.
I think our general strategy should be to aggressive in marking things as flaky, and cautious about un-marking them. There's also no harm in marking something flaky and immediately removing the tag in a subsequent PR (assuming we are confident in the fix).
There was a problem hiding this comment.
Would you mind taking a look at my PR fixing it? 😉
frankvicky
left a comment
frankvicky
left a comment
There was a problem hiding this comment.
LGTM
It's more effective to manage this flaky test instead of disabling it.
…e-old-protocol-versions * apache-github/trunk: KAFKA-18312: Added entityType: topicName to SubscribedTopicNames in ShareGroupHeartbeatRequest.json (apache#18285) HOTFIX: fix incompatible types: Optional<TimestampAndOffset> cannot be converted to Option<TimestampAndOffset> (apache#18284) MINOR Fix some test-catalog issues (apache#18272) KAFKA-18180: Move OffsetResultHolder to storage module (apache#18100) KAFKA-18301; Make coordinator records first class citizen (apache#18261) KAFKA-18262 Remove DefaultPartitioner and UniformStickyPartitioner (apache#18204) KAFKA-18296 Remove deprecated KafkaBasedLog constructor (apache#18257) KAFKA-12829: Remove old Processor and ProcessorSupplier interfaces (apache#18238) KAFKA-18292 Remove deprecated methods of UpdateFeaturesOptions (apache#18245) KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API (apache#18154) KAFKA-18035, KAFKA-18306, KAFKA-18092: Address TransactionsTest flaky tests (apache#18264) MINOR: change the default linger time in the new coordinator (apache#18274) KAFKA-18305: validate controller.listener.names is not in inter.broker.listener.name for kcontrollers (apache#18222) KAFKA-18207: Serde for handling transaction records (apache#18136) KAFKA-13722: Refactor Kafka Streams store interfaces (apache#18243) KAFKA-17131: Refactor TimeDefinitions (apache#18241) MINOR: Fix MessageFormatters (apache#18266) Mark flaky tests for Dec 18, 2024 (apache#18263)
Reviewers: TengYao Chi <kitingiao@gmail.com>, Andrew Schofield <aschofield@confluent.io>
5 participants
Marking a few flaky tests.