Skip to content

MINOR: change the default linger time in the new coordinator#18274

Merged
jeffkbkim merged 1 commit intoapache:trunkfrom
jeffkbkim:minor-change-default-linger
Dec 19, 2024
Merged

MINOR: change the default linger time in the new coordinator#18274
jeffkbkim merged 1 commit intoapache:trunkfrom
jeffkbkim:minor-change-default-linger

Conversation

@jeffkbkim
Copy link
Copy Markdown
Contributor

10 millisecond delay for low traffic clusters is quite impacting as offset commit total time increases by +10ms which is very high compared to single digit offset commit total times in the old coordinator.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions Bot added triage PRs from the community small Small PRs labels Dec 19, 2024
@jeffkbkim jeffkbkim added the KIP-848 The Next Generation of the Consumer Rebalance Protocol label Dec 19, 2024
Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please update the kip too.

@jeffkbkim
Copy link
Copy Markdown
Contributor Author

Added following configs to kip


group.coordinator.new.enable | boolean | true | To enable the new group coordinator.
group.coordinator.rebalance.protocols | list | "classic,consumer" | The list of enabled rebalance protocols.
group.coordinator.append.linger.ms | int | 5ms | The duration that the coordinator will wait for writes to accumulate before flushing to disk (not applicable to txn writes).

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217387038#KIP848:TheNextGenerationoftheConsumerRebalanceProtocol-BrokerConfigurations

@dajac
Copy link
Copy Markdown
Member

dajac commented Dec 19, 2024

Don't add group.coordinator.new.enable. This is an internal config. It is not supposed to be public.

@jeffkbkim jeffkbkim merged commit cd08129 into apache:trunk Dec 19, 2024
@jeffkbkim jeffkbkim deleted the minor-change-default-linger branch December 19, 2024 21:54
@github-actions github-actions Bot removed the triage PRs from the community label Dec 20, 2024
@dajac
Copy link
Copy Markdown
Member

dajac commented Dec 20, 2024

@jeffkbkim Please don’t forget to mention reviewers in the commit message. Please also cherry-pick this commit to the 4.0 branch.

@jeffkbkim
Copy link
Copy Markdown
Contributor Author

cherry picked to 4.0

ijuma added a commit to ijuma/kafka that referenced this pull request Dec 20, 2024
…e-old-protocol-versions

* apache-github/trunk:
  KAFKA-18312: Added entityType: topicName to SubscribedTopicNames in ShareGroupHeartbeatRequest.json (apache#18285)
  HOTFIX: fix incompatible types: Optional<TimestampAndOffset> cannot be converted to Option<TimestampAndOffset> (apache#18284)
  MINOR Fix some test-catalog issues (apache#18272)
  KAFKA-18180: Move OffsetResultHolder to storage module (apache#18100)
  KAFKA-18301; Make coordinator records first class citizen (apache#18261)
  KAFKA-18262 Remove DefaultPartitioner and UniformStickyPartitioner (apache#18204)
  KAFKA-18296 Remove deprecated KafkaBasedLog constructor (apache#18257)
  KAFKA-12829: Remove old Processor and ProcessorSupplier interfaces (apache#18238)
  KAFKA-18292 Remove deprecated methods of UpdateFeaturesOptions (apache#18245)
  KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API (apache#18154)
  KAFKA-18035, KAFKA-18306, KAFKA-18092: Address TransactionsTest flaky tests (apache#18264)
  MINOR: change the default linger time in the new coordinator (apache#18274)
  KAFKA-18305: validate controller.listener.names is not in inter.broker.listener.name for kcontrollers (apache#18222)
  KAFKA-18207: Serde for handling transaction records (apache#18136)
  KAFKA-13722: Refactor Kafka Streams store interfaces (apache#18243)
  KAFKA-17131: Refactor TimeDefinitions (apache#18241)
  MINOR: Fix MessageFormatters (apache#18266)
  Mark flaky tests for Dec 18, 2024 (apache#18263)
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KIP-848 The Next Generation of the Consumer Rebalance Protocol small Small PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants