Skip to content

KAFKA-13722: Refactor Kafka Streams store interfaces#18243

Merged
mjsax merged 1 commit intoapache:trunkfrom
mjsax:kafka-13722-processorcontext-segments
Dec 19, 2024
Merged

KAFKA-13722: Refactor Kafka Streams store interfaces#18243
mjsax merged 1 commit intoapache:trunkfrom
mjsax:kafka-13722-processorcontext-segments

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Dec 18, 2024

Refactor Segments and TimestampedSegments to not use old ProcessorContext any longer.

@mjsax
KAFKA-13722: Refactor Kafka Streams store interfaces
3c5a472 
Refactor Segments and TimestampedSegments to not use old
ProcessorContext any longer.
@mjsax mjsax added the streams label Dec 18, 2024
@github-actions github-actions Bot added the small Small PRs label Dec 18, 2024
cadonna
cadonna approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @mjsax !

LGTM!

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 18, 2024

Java 23:

FAILED ❌ UserQuotaTest > testThrottledProducerConsumer(String, String).quorum=kraft.groupProtocol=consumer
FAILED ❌ UserQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=classic
FAILED ❌ UserQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=consumer
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroups(String, String).quorum=kraft.groupProtocol=consumer
Found 1 flaky test failures:
FLAKY ⚠️  TransactionsWithTieredStoreTest > "testBumpTransactionalEpochWithTV2Enabled(String, String, boolean).quorum=kraft, groupProtocol=classic, isTV2Enabled=true"

Java 17:

Found 1 test failures:
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroups(String, String).quorum=kraft.groupProtocol=consumer
Found 1 flaky test failures:
FLAKY ⚠️  TransactionsWithTieredStoreTest > testFailureToFenceEpoch(String, String, boolean).quorum=kraft.groupProtocol=consumer.isTV2Enabled=true

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

Java 17 passed.

Java 23:

Found 1 test failures:
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroups(String, String).quorum=kraft.groupProtocol=consumer
Found 2 flaky test failures:
FLAKY ⚠️  TransactionsWithTieredStoreTest > "testBumpTransactionalEpochWithTV2Enabled(String, String, boolean).quorum=kraft, groupProtocol=consumer, isTV2Enabled=true"
FLAKY ⚠️  UserQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=consumer

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

Java 23:

Found 3 test failures:
FAILED ❌ UserQuotaTest > testQuotaOverrideDelete(String, String).quorum=kraft.groupProtocol=consumer
FAILED ❌ PlaintextConsumerCallbackTest > testGetPositionOfNewlyAssignedPartitionOnPartitionsAssignedCallback(String, String).quorum=kraft.groupProtocol=consumer
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer
Found 1 flaky test failures:
FLAKY ⚠️  TransactionsWithTieredStoreTest > testReadCommittedConsumerShouldNotSeeUndecidedData(String, String).quorum=kraft.groupProtocol=consumer

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

We know that PlaintextAdminIntegrationTest is flaky -- different test failed for the last two runs. Merging.

@mjsax mjsax merged commit b3b40bb into apache:trunk Dec 19, 2024
@mjsax mjsax deleted the kafka-13722-processorcontext-segments branch December 19, 2024 19:56
mjsax added a commit that referenced this pull request Dec 19, 2024
@mjsax
KAFKA-13722: Refactor Kafka Streams store interfaces (#18243)
79de8ee 
Refactor Segments and TimestampedSegments to not use old
ProcessorContext any longer.

Reviewers: Bruno Cadonna <bruno@confluent.io>
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

Merged to trunk and cherry-picked to 4.0.

ijuma added a commit to ijuma/kafka that referenced this pull request Dec 20, 2024
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into kip-896-remov…
31a4619 
…e-old-protocol-versions

* apache-github/trunk:
  KAFKA-18312: Added entityType: topicName to SubscribedTopicNames in ShareGroupHeartbeatRequest.json (apache#18285)
  HOTFIX: fix incompatible types: Optional<TimestampAndOffset> cannot be converted to Option<TimestampAndOffset> (apache#18284)
  MINOR Fix some test-catalog issues (apache#18272)
  KAFKA-18180: Move OffsetResultHolder to storage module (apache#18100)
  KAFKA-18301; Make coordinator records first class citizen (apache#18261)
  KAFKA-18262 Remove DefaultPartitioner and UniformStickyPartitioner (apache#18204)
  KAFKA-18296 Remove deprecated KafkaBasedLog constructor (apache#18257)
  KAFKA-12829: Remove old Processor and ProcessorSupplier interfaces (apache#18238)
  KAFKA-18292 Remove deprecated methods of UpdateFeaturesOptions (apache#18245)
  KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API (apache#18154)
  KAFKA-18035, KAFKA-18306, KAFKA-18092: Address TransactionsTest flaky tests (apache#18264)
  MINOR: change the default linger time in the new coordinator (apache#18274)
  KAFKA-18305: validate controller.listener.names is not in inter.broker.listener.name for kcontrollers (apache#18222)
  KAFKA-18207: Serde for handling transaction records (apache#18136)
  KAFKA-13722: Refactor Kafka Streams store interfaces (apache#18243)
  KAFKA-17131: Refactor TimeDefinitions (apache#18241)
  MINOR: Fix MessageFormatters (apache#18266)
  Mark flaky tests for Dec 18, 2024 (apache#18263)
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
@mjsax @tedyu
KAFKA-13722: Refactor Kafka Streams store interfaces (apache#18243)
a36d8a5 
Refactor Segments and TimestampedSegments to not use old
ProcessorContext any longer.

Reviewers: Bruno Cadonna <bruno@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cadonna cadonna cadonna approved these changes

Assignees

No one assigned

Labels

small Small PRs streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjsax @cadonna