Skip to content

KAFKA-17131: Refactor TimeDefinitions#18241

Merged
mjsax merged 1 commit intoapache:trunkfrom
mjsax:kafka-17131-processorcontext-timedefinition
Dec 19, 2024
Merged

KAFKA-17131: Refactor TimeDefinitions#18241
mjsax merged 1 commit intoapache:trunkfrom
mjsax:kafka-17131-processorcontext-timedefinition

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Dec 18, 2024 •
edited
Loading

Refactor TimeDefintiions to not use old ProcessorContext any longer.

@mjsax
KAFKA-17131: Refactor TimeDefinitions
f084eae 
Refactor TimeDefintiions to not use old ProcessorContext any longer
@mjsax mjsax added the streams label Dec 18, 2024
mjsax
mjsax commented Dec 18, 2024
View reviewed changes
Comment thread streams/src/main/java/org/apache/kafka/streams/kstream/Suppressed.java
* Create a buffer unconstrained by size (either keys or bytes).
*
* As a result, the buffer will consume as much memory as it needs, dictated by the time bound.
* <p>As a result, the buffer will consume as much memory as it needs, dictated by the time bound.
Copy link
Copy Markdown
Member Author

@mjsax mjsax Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some side cleanup in related code...

cadonna
cadonna approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @mjsax !

LGTM!

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 18, 2024

I am a little "worried" about the failing test -- they are clearly unrelated, but should we fall back into a bad pattern and merge PRs w/o green build (on the other hand, it does not really buy us much to wait for these tests to get fixes...)

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 18, 2024 •
edited
Loading

Java 23:

Found 1 test failures:
FAILED ❌ KafkaAdminClientTest > testAdminClientApisAuthenticationFailure()
Found 3 flaky test failures:
FLAKY ⚠️  TransactionsWithTieredStoreTest > testReadCommittedConsumerShouldNotSeeUndecidedData(String, String).quorum=kraft.groupProtocol=consumer
FLAKY ⚠️  SslAdminIntegrationTest > "testCreateTopicsResponseMetadataAndConfig(String).quorum=kraft"
FLAKY ⚠️  DefaultStateUpdaterTest > shouldThrowIfAddingStandbyTasksWithSameId()

Java 17:

Found 1 test failures:
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer
Found 3 flaky test failures:
FLAKY ⚠️  TransactionsWithTieredStoreTest > "testBumpTransactionalEpochWithTV2Disabled(String, String, boolean).quorum=kraft, groupProtocol=classic, isTV2Enabled=false"
FLAKY ⚠️  TransactionsWithTieredStoreTest > "testBumpTransactionalEpochWithTV2Enabled(String, String, boolean).quorum=kraft, groupProtocol=consumer, isTV2Enabled=true"
FLAKY ⚠️  PlaintextAdminIntegrationTest > "testElectPreferredLeaders(String).quorum=kraft"

@cadonna
Copy link
Copy Markdown
Member

cadonna commented Dec 18, 2024

I am a little "worried" about the failing test -- they are clearly unrelated, but should we fall back into a bad pattern and merge PRs w/o green build

No, we should not fall back!

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

Talked to David about the failing "Scan" task, and he told me, it's ok to merge w/o it passing. He did identify the problem already, and opened a PR to fix it: #18272

@mjsax mjsax merged commit fe9847d into apache:trunk Dec 19, 2024
@mjsax mjsax deleted the kafka-17131-processorcontext-timedefinition branch December 19, 2024 19:40
mjsax added a commit that referenced this pull request Dec 19, 2024
@mjsax
KAFKA-17131: Refactor TimeDefinitions (#18241)
5667189 
Refactor TimeDefintiions to not use old ProcessorContext any longer.

Reviewers: Bruno Cadonna <bruno@confluent.io>
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Dec 19, 2024

Merged to trunk and cherry-picked to 4.0.

ijuma added a commit to ijuma/kafka that referenced this pull request Dec 20, 2024
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into kip-896-remov…
31a4619 
…e-old-protocol-versions

* apache-github/trunk:
  KAFKA-18312: Added entityType: topicName to SubscribedTopicNames in ShareGroupHeartbeatRequest.json (apache#18285)
  HOTFIX: fix incompatible types: Optional<TimestampAndOffset> cannot be converted to Option<TimestampAndOffset> (apache#18284)
  MINOR Fix some test-catalog issues (apache#18272)
  KAFKA-18180: Move OffsetResultHolder to storage module (apache#18100)
  KAFKA-18301; Make coordinator records first class citizen (apache#18261)
  KAFKA-18262 Remove DefaultPartitioner and UniformStickyPartitioner (apache#18204)
  KAFKA-18296 Remove deprecated KafkaBasedLog constructor (apache#18257)
  KAFKA-12829: Remove old Processor and ProcessorSupplier interfaces (apache#18238)
  KAFKA-18292 Remove deprecated methods of UpdateFeaturesOptions (apache#18245)
  KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API (apache#18154)
  KAFKA-18035, KAFKA-18306, KAFKA-18092: Address TransactionsTest flaky tests (apache#18264)
  MINOR: change the default linger time in the new coordinator (apache#18274)
  KAFKA-18305: validate controller.listener.names is not in inter.broker.listener.name for kcontrollers (apache#18222)
  KAFKA-18207: Serde for handling transaction records (apache#18136)
  KAFKA-13722: Refactor Kafka Streams store interfaces (apache#18243)
  KAFKA-17131: Refactor TimeDefinitions (apache#18241)
  MINOR: Fix MessageFormatters (apache#18266)
  Mark flaky tests for Dec 18, 2024 (apache#18263)
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
@mjsax @tedyu
KAFKA-17131: Refactor TimeDefinitions (apache#18241)
1c34603 
Refactor TimeDefintiions to not use old ProcessorContext any longer.

Reviewers: Bruno Cadonna <bruno@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cadonna cadonna cadonna approved these changes

Assignees

No one assigned

Labels

streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjsax @cadonna