KAFKA-18353: Remove zk config control.plane.listener.name#18329
KAFKA-18353: Remove zk config control.plane.listener.name#18329chia7712 merged 12 commits intoapache:trunkfrom
control.plane.listener.name#18329Conversation
TaiJuWu
force-pushed
the
contol.plnae
branch
from
8b48de0 to
5f15b0a
Compare
TaiJuWu
force-pushed
the
contol.plnae
branch
from
9375b42 to
c6b682d
Compare
This reverts commit c6b682d.
| </li> | ||
| <li>The function <code>onNewBatch</code> in <code>org.apache.kafka.clients.producer.Partitioner</code> class was removed. | ||
| </li> | ||
| <li>The <code>control.plane.listener.name</code> config was removed. |
There was a problem hiding this comment.
@chia7712 My point is that a lot more than this config will be removed as part of ZK removal. Why are we listing this one specifically? As I stated elsewhere, we should have a note saying that ZK support has been removed with a link to all the implications as well as the migration details.
There was a problem hiding this comment.
My point is that a lot more than this config will be removed as part of ZK removal. Why are we listing this one specifically? As I stated elsewhere, we should have a note saying that ZK support has been removed with a link to all the implications as well as the migration details.
I completely agree that comprehensive migration details are necessary. However, since the documentation for these details may require further discussion, let's address them as a follow-up to avoid delaying the code cleanup. @TaiJuWu has already opened https://issues.apache.org/jira/browse/KAFKA-18364 to track the documentation effort.
In the meantime, could we create a temporary section listing the configurations removed due to Zookeeper? Once the migration details are finalized in KAFKA-18364, this temporary section can be replaced with a more thorough explanation. The temporary section is a note in KAFKA-18364 to ensure all implications are considered.
There was a problem hiding this comment.
Yes, I think we can make a note in that JIRA instead of the upgrade notes.
There was a problem hiding this comment.
Remove upgrade notes and this JIRA already link to KAFKA-18364
There was a problem hiding this comment.
@frankvicky could you please file a minor to remove the password configs form the upgrade.html in order to follow @ijuma suggestion? I have added the link to KAFKA-18364
|
@TaiJuWu please fix the build error |
Thanks for remind, it should be fixed now. |
| }.sum | ||
| }) | ||
| if (config.requiresZookeeper) { | ||
| metricsGroup.newGauge(s"${ControlPlaneAcceptor.MetricPrefix}ExpiredConnectionsKilledCount", () => SocketServer.this.synchronized { |
| } | ||
| }) | ||
| if (config.requiresZookeeper) { | ||
| metricsGroup.newGauge(s"${ControlPlaneAcceptor.MetricPrefix}NetworkProcessorAvgIdlePercent", () => SocketServer.this.synchronized { |
| // Configure control plane listener to make sure we have separate listeners for testing. | ||
| val serverProperties = new java.util.HashMap[String, String]() | ||
| serverProperties.put(SocketServerConfigs.CONTROL_PLANE_LISTENER_NAME_CONFIG, controlPlaneListenerName) | ||
| serverProperties.put(SocketServerConfigs.LISTENER_SECURITY_PROTOCOL_MAP_CONFIG, s"$controlPlaneListenerName:$securityProtocol,$securityProtocol:$securityProtocol") |
There was a problem hiding this comment.
I think controlPlaneListenerName is unnecessary to this test, but this test is disabled for now. Maybe we can revisit it in KAFKA-17631
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
3 participants
JIRA: https://issues.apache.org/jira/browse/KAFKA-18353
Committer Checklist (excluded from commit message)