KAFKA-17631: Convert SaslApiVersionsRequestTest to kraft#18330
Merged
chia7712 merged 1 commit intoapache:trunkfrom Feb 3, 2025
Merged
KAFKA-17631: Convert SaslApiVersionsRequestTest to kraft#18330chia7712 merged 1 commit intoapache:trunkfrom
chia7712 merged 1 commit intoapache:trunkfrom
Conversation
3 tasks
FrankYang0529
force-pushed
the
KAFKA-17631
branch
from
ba8704b to
53411f1
Compare
github-actions
Bot
added
tests
FrankYang0529
force-pushed
the
KAFKA-17631
branch
3 times, most recently
from
a63ee08 to
0ce76b6
Compare
Member
|
@FrankYang0529 could you please fix the conflicts? |
FrankYang0529
force-pushed
the
KAFKA-17631
branch
from
0ce76b6 to
71173e0
Compare
Member
Author
Resolved conflict. Thanks. |
FrankYang0529
force-pushed
the
KAFKA-17631
branch
7 times, most recently
from
e921346 to
298e21b
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-17631
branch
from
298e21b to
4a19220
Compare
chia7712
approved these changes
Feb 3, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
LGTM and one unrelated question
|
|
||
| @AfterEach | ||
| def closeSasl(): Unit = { | ||
| sasl.closeSasl() |
Member
There was a problem hiding this comment.
I'm considering whether we need to close all login modules within Testkit. However, these modules are primarily used to prevent consumer leaks, and we already have thread detection mechanisms in place. @FrankYang0529 WDYT?
Member
Author
There was a problem hiding this comment.
I think we can keep it as current implementation since we have thread leak detection. We can catch error if there is thread leak.
chia7712
pushed a commit
that referenced
this pull request
Feb 3, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We disabled
SaslApiVersionsRequestTestwhen implementing KAFKA-17614. Re-enable with a new test framework.Committer Checklist (excluded from commit message)