KAFKA-18435: Remove zookeeper dependencies in build.gradle#18450
Merged
chia7712 merged 1 commit intoapache:trunkfrom Jan 9, 2025
Merged
KAFKA-18435: Remove zookeeper dependencies in build.gradle#18450chia7712 merged 1 commit intoapache:trunkfrom
chia7712 merged 1 commit intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
github-actions
Bot
added
the
dependencies
ijuma
reviewed
Jan 8, 2025
| val targetDirFile = new File(targetParentDir, log.dir.getName) | ||
| FileUtils.copyDirectory(log.dir, targetDirFile) | ||
| targetDirFile.mkdir() | ||
| copyDirectory(log.dir.toString(), targetDirFile.toString()) |
Contributor
Author
There was a problem hiding this comment.
This test used commons-io, which is being removed. (commons-io is generally redundant with the new Java stuff, but was a ZK dependency.)
This change fixes the test not to use commons-io.
chia7712
approved these changes
Jan 9, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
LGTM
the failed tests are traced by https://issues.apache.org/jira/browse/KAFKA-9655 and https://issues.apache.org/jira/browse/KAFKA-18456, and they pass on my local
| enableEntityConfigControllerCheck: Boolean | ||
| ) extends AutoCloseable with Logging { | ||
|
|
||
| private val metricsGroup: KafkaMetricsGroup = new KafkaMetricsGroup("kafka.server", "ZooKeeperClientMetrics") |
Member
chia7712
pushed a commit
to chia7712/kafka
that referenced
this pull request
Jan 9, 2025
Remove Apache ZooKeeper from the Apache Kafka build. Also remove commons IO, commons CLI, and netty, which were dependencies we took only because of ZooKeeper. In order to keep the size of this PR manageable, I did not remove all classes which formerly interfaced with ZK. I just removed the ZK types. Fortunately, Kafka generally wrapped ZK data structures rather than using them directly. Some classes were pretty entangled with ZK, so it was easier just to stub them out. For ZkNodeChangeNotificationListener.scala, PartitionStateMachine.scala, ReplicaStateMachine.scala, KafkaZkClient.scala, and ZookeeperClient.scala, I replaced all the functions with "throw new UnsupportedOperationException". Since the tests for these classes have been removed, as well as the ZK-based broker code, this should be OK as an incremental step. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Remove Apache ZooKeeper from the Apache Kafka build. Also remove commons IO, commons CLI, and netty, which were dependencies we took only because of ZooKeeper. In order to keep the size of this PR manageable, I did not remove all classes which formerly interfaced with ZK. I just removed the ZK types. Fortunately, Kafka generally wrapped ZK data structures rather than using them directly. Some classes were pretty entangled with ZK, so it was easier just to stub them out. For ZkNodeChangeNotificationListener.scala, PartitionStateMachine.scala, ReplicaStateMachine.scala, KafkaZkClient.scala, and ZookeeperClient.scala, I replaced all the functions with "throw new UnsupportedOperationException". Since the tests for these classes have been removed, as well as the ZK-based broker code, this should be OK as an incremental step. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
chia7712
reviewed
Jan 31, 2025
| @volatile private var zooKeeper = new ZooKeeper(connectString, sessionTimeoutMs, ZooKeeperClientWatcher, | ||
| clientConfig) | ||
|
|
||
| metricsGroup.newGauge("SessionState", () => connectionState.toString) |
3 tasks
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Remove Apache ZooKeeper from the Apache Kafka build. Also remove commons IO, commons CLI, and netty, which were dependencies we took only because of ZooKeeper. In order to keep the size of this PR manageable, I did not remove all classes which formerly interfaced with ZK. I just removed the ZK types. Fortunately, Kafka generally wrapped ZK data structures rather than using them directly. Some classes were pretty entangled with ZK, so it was easier just to stub them out. For ZkNodeChangeNotificationListener.scala, PartitionStateMachine.scala, ReplicaStateMachine.scala, KafkaZkClient.scala, and ZookeeperClient.scala, I replaced all the functions with "throw new UnsupportedOperationException". Since the tests for these classes have been removed, as well as the ZK-based broker code, this should be OK as an incremental step. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
powersj
pushed a commit
to wolfi-dev/os
that referenced
this pull request
Feb 21, 2025
Found no interdependency conflicts in any of the kafka branches as it is just used for zookeeper, so am patching the gradle dependency. This will change for later releases of 3.9 as they will be restructuring how this dependency is read as seen here: apache/kafka#18450
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Apache ZooKeeper from the Apache Kafka build. Also remove commons IO, commons CLI, and netty, which were dependencies we took only because of ZooKeeper.
In order to keep the size of this PR manageable, I did not remove all classes which formerly interfaced with ZK. I just removed the ZK types. Fortunately, Kafka generally wrapped ZK data structures rather than using them directly.
Some classes were pretty entangled with ZK, so it was easier just to stub them out. For ZkNodeChangeNotificationListener.scala, PartitionStateMachine.scala, ReplicaStateMachine.scala, KafkaZkClient.scala, and ZookeeperClient.scala, I replaced all the functions with "throw new UnsupportedOperationException". Since the tests for these classes have been removed, as well as the ZK-based broker code, this should be OK as an incremental step.