MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient#18775
Merged
chia7712 merged 2 commits intoapache:trunkfrom Feb 3, 2025
Merged
MINOR: Remove the test for ZooKeeper metrics used by ZooKeeperClient#18775chia7712 merged 2 commits intoapache:trunkfrom
chia7712 merged 2 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
Member
|
Looks like we removed the tests, but what about the code that is ensuring the test was passing - it doesn't seem to be removed in this PR? |
Yunyung
changed the title
Collaborator
Author
|
The metrics were removed in #18450, but the test and documentation were forgotten. Also, corrected the wording in this PR to avoid misunderstanding. |
Member
|
Why do the test passing though - that seems odd. |
Collaborator
Author
|
Yeah, here: 42ea29c#diff-5bc93ef5ce2e7ef966957f547fe93aa295042c90e92a29d44153e5b434bd952fR271 and 434fe7c#diff-5bc93ef5ce2e7ef966957f547fe93aa295042c90e92a29d44153e5b434bd952fR251, the changes ensure that KRaft has no such metrics and do not test ZooKeeper. So the test always passed before. |
m1a2st
approved these changes
Feb 2, 2025
Collaborator
m1a2st
left a comment
m1a2st
left a comment
There was a problem hiding this comment.
Thanks for this patch, LGTM
m1a2st
approved these changes
Feb 3, 2025
chia7712
approved these changes
Feb 3, 2025
chia7712
pushed a commit
to chia7712/kafka
that referenced
this pull request
Feb 3, 2025
…pache#18775) Reviewers: Ismael Juma <ismael@juma.me.uk>, Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
…pache#18775) Reviewers: Ismael Juma <ismael@juma.me.uk>, Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…pache#18775) Reviewers: Ismael Juma <ismael@juma.me.uk>, Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the test for three metrics already removed in #18450, used only by ZooKeeper, and document them.
Committer Checklist (excluded from commit message)