KAFKA-18399: Remove ZooKeeper from KafkaApis (3/N): USER_SCRAM_CREDENTIALS#18456
Merged
chia7712 merged 1 commit intoapache:trunkfrom Jan 12, 2025
Merged
KAFKA-18399: Remove ZooKeeper from KafkaApis (3/N): USER_SCRAM_CREDENTIALS#18456chia7712 merged 1 commit intoapache:trunkfrom
chia7712 merged 1 commit intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
frankvicky
changed the title
| @@ -3370,10 +3370,7 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| } else { | |||
| metadataSupport match { | |||
| case ZkSupport(adminManager, controller, zkClient, forwardingManager, metadataCache, _) => | |||
Member
There was a problem hiding this comment.
If we will eventually remove zk related code, probably we can use case default here and avoid to use ZkSupport.
frankvicky
force-pushed
the
KAFKA-18399
branch
from
183998e to
aed36ec
Compare
FrankYang0529
approved these changes
Jan 9, 2025
Member
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch.
frankvicky
force-pushed
the
KAFKA-18399
branch
from
aed36ec to
6c48c3d
Compare
ijuma
reviewed
Jan 10, 2025
| requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs => | ||
| alterUserScramCredentialsRequest.getErrorResponse(requestThrottleMs, Errors.CLUSTER_AUTHORIZATION_FAILED.exception)) | ||
| } | ||
| throw KafkaApis.shouldAlwaysForward(request) |
Member
There was a problem hiding this comment.
Same thing I said here: https://github.com/apache/kafka/pull/18465/files#r1910472130
Member
There was a problem hiding this comment.
@frankvicky Could you please refactor maybeForwardToController to forwardToController? We will remove all zk-releated handlers, so it is fine to do refactor in this PR. With that change, the handle handleAlterUserScramCredentialsRequest can be removed directly
frankvicky
force-pushed
the
KAFKA-18399
branch
from
6c48c3d to
feaafc5
Compare
TaiJuWu
approved these changes
Jan 10, 2025
Collaborator
TaiJuWu
left a comment
TaiJuWu
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this fix.
frankvicky
force-pushed
the
KAFKA-18399
branch
2 times, most recently
from
dda5314 to
99fe806
Compare
frankvicky
force-pushed
the
KAFKA-18399
branch
from
99fe806 to
3c9d632
Compare
chia7712
reviewed
Jan 11, 2025
| @@ -3173,37 +3161,16 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| describeUserScramCredentialsRequest.getErrorResponse(requestThrottleMs, Errors.CLUSTER_AUTHORIZATION_FAILED.exception)) | |||
| } else { | |||
| metadataSupport match { | |||
Member
There was a problem hiding this comment.
Could you please change the type of metadataSupport to RaftSupport?
Member
There was a problem hiding this comment.
oh, that will be handled by #18483. please ignore above comment
frankvicky
force-pushed
the
KAFKA-18399
branch
from
3c9d632 to
c203485
Compare
chia7712
approved these changes
Jan 12, 2025
chia7712
pushed a commit
that referenced
this pull request
Jan 12, 2025
…IALS (#18456) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
chia7712
changed the title
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…IALS (apache#18456) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…IALS (apache#18456) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…IALS (apache#18456) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18399
This is a part of KAFKA-18399 and it's focus on clean up
ALTER_USER_SCRAM_CREDENTIALSandDESCRIBE_USER_SCRAM_CREDENTIALSCommitter Checklist (excluded from commit message)