KAFKA-18472: Remove MetadataSupport#18483
Merged
ijuma merged 14 commits intoapache:trunkfrom Jan 16, 2025
Merged
Conversation
m1a2st
changed the title
3 tasks
# Conflicts: # core/src/main/scala/kafka/server/KafkaApis.scala
# Conflicts: # core/src/main/scala/kafka/server/KafkaApis.scala
Member
|
@m1a2st please fix conflicts |
# Conflicts: # core/src/main/scala/kafka/server/KafkaApis.scala
m1a2st
changed the title
3 tasks
ijuma
reviewed
Jan 15, 2025
| new DescribeClientQuotasResponse(result) | ||
| }) | ||
| } | ||
| val result = metadataCache.asInstanceOf[KRaftMetadataCache]describeClientQuotas(describeClientQuotasRequest.data()) |
Member
There was a problem hiding this comment.
Do we have a JIRA for removing this cast? There should be no reason to do casts anymore since the only implementation we have is this one.
Collaborator
Author
There was a problem hiding this comment.
There is a Jira to remove zkMetadataCache, I think we should also addressed it in this Jira
Member
|
@m1a2st please fix the conflicts |
# Conflicts: # core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
3 tasks
Member
|
I believe we can eliminate |
Collaborator
Author
|
It make sense to me, I will change to remove all |
m1a2st
changed the title
chia7712
reviewed
Jan 15, 2025
| requestHelper.sendMaybeThrottle(request, subscriptionRequest.getErrorResponse(Errors.INVALID_REQUEST.exception)) | ||
| } | ||
| case None => | ||
| info("Received get telemetry client request for zookeeper based cluster") |
Member
There was a problem hiding this comment.
Could you please revert this change as it is included by #18550?
| requestHelper.sendMaybeThrottle(request, pushTelemetryRequest.getErrorResponse(Errors.INVALID_REQUEST.exception)) | ||
| } | ||
| case None => | ||
| info("Received push telemetry client request for zookeeper based cluster") |
| // This should never happen as ZK based cluster calls should get rejected earlier itself, | ||
| // This should never happen as based cluster calls should get rejected earlier itself, | ||
| // but we should handle it gracefully. | ||
| info("Received list client metrics resources request for zookeeper based cluster") |
| case Some(manager) => manager | ||
| case None => | ||
| // The API is not supported when the SharePartitionManager is not defined on the broker | ||
| info("Received share acknowledge request for zookeeper based cluster") |
| case Some(manager) => manager | ||
| case None => | ||
| // The API is not supported when the SharePartitionManager is not defined on the broker | ||
| info("Received share fetch request for zookeeper based cluster") |
# Conflicts: # core/src/main/scala/kafka/server/KafkaApis.scala
ijuma
reviewed
Jan 16, 2025
| new DescribeClientQuotasResponse(result) | ||
| }) | ||
| } | ||
| val result = metadataCache.asInstanceOf[KRaftMetadataCache].describeClientQuotas(describeClientQuotasRequest.data()) |
Member
There was a problem hiding this comment.
A note for someone who sees this - there is a plan to address these casts separately. My suggestion elsewhere is to simply move the relevant methods to the base interface and then the cast is no longer needed.
Collaborator
Author
There was a problem hiding this comment.
Thanks for @ijuma reminder, cc @FrankYang0529
ijuma
pushed a commit
that referenced
this pull request
Jan 16, 2025
Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18472
Committer Checklist (excluded from commit message)