KAFKA-18539: Remove optional managers in KafkaApis#18550
Merged
chia7712 merged 6 commits intoapache:trunkfrom Jan 15, 2025
Merged
KAFKA-18539: Remove optional managers in KafkaApis#18550chia7712 merged 6 commits intoapache:trunkfrom
chia7712 merged 6 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
Member
|
@apoorvmittal10 sorry that my recent merge causes some conflicts on this PR. Could you please fix them? |
Contributor
Author
I rebased. |
mimaison
reviewed
Jan 15, 2025
| requestHelper.sendMaybeThrottle(request, listClientMetricsResourcesRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception)) | ||
| } | ||
| val data = new ListClientMetricsResourcesResponseData().setClientMetricsResources( | ||
| clientMetricsManager.listClientMetricsResources.asScala.map( |
Member
There was a problem hiding this comment.
It looks like we could avoid the asScala -> asJava here
Contributor
Author
There was a problem hiding this comment.
Moved to stream and collector, removed asScala and asJava conversions.
Member
There was a problem hiding this comment.
Let's mention this change in the PR description since it's unrelated to the core change.
chia7712
approved these changes
Jan 15, 2025
| } | ||
| val data = new ListClientMetricsResourcesResponseData().setClientMetricsResources( | ||
| clientMetricsManager.listClientMetricsResources.stream.map( | ||
| name => new ClientMetricsResource().setName(name)).collect(Collectors.toList())) |
Member
There was a problem hiding this comment.
nit: collect(Collectors.toList()) -> toList
3 tasks
Contributor
Author
|
Build passed on Java 23, unrelated test failure on Java 17. |
chia7712
pushed a commit
that referenced
this pull request
Jan 15, 2025
Removed Optional for SharePartitionManager and ClientMetricsManager as zookeeper code is being removed. Also removed asScala and asJava conversion in KafkaApis.handleListClientMetricsResources, moved to java stream. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Removed Optional for SharePartitionManager and ClientMetricsManager as zookeeper code is being removed. Also removed asScala and asJava conversion in KafkaApis.handleListClientMetricsResources, moved to java stream. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Removed Optional for SharePartitionManager and ClientMetricsManager as zookeeper code is being removed. Also removed asScala and asJava conversion in KafkaApis.handleListClientMetricsResources, moved to java stream. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Removed Optional for SharePartitionManager and ClientMetricsManager as zookeeper code is being removed. Also removed asScala and asJava conversion in KafkaApis.handleListClientMetricsResources, moved to java stream. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Optional for SharePartitionManager and ClientMetricsManager as zookeeper code is being removed. Also removed
asScalaandasJavaconversion inKafkaApis.handleListClientMetricsResources, moved to javastream.Committer Checklist (excluded from commit message)