KAFKA-18499 Clean up zookeeper from LogConfig#18583
Merged
chia7712 merged 4 commits intoapache:trunkfrom Jan 25, 2025
Merged
Conversation
github-actions
Bot
added
triage
m1a2st
reviewed
Jan 17, 2025
Collaborator
m1a2st
left a comment
m1a2st
left a comment
There was a problem hiding this comment.
Hello @mingdaoy, Thanks for this PR. Please also cleanup the LogManager.scala, there are some comments and code still contained zookeeper.
Collaborator
|
https://issues.apache.org/jira/browse/KAFKA-18544 also can handle in this PR, WDYT? |
github-actions
Bot
added
storage
mingdaoy
changed the title
Contributor
Author
|
|
mingdaoy
force-pushed
the
KAFKA-18499
branch
2 times, most recently
from
d0f6877 to
f6eafba
Compare
chia7712
reviewed
Jan 24, 2025
| class BrokerConfigHandler(private val brokerConfig: KafkaConfig, | ||
| private val quotaManagers: QuotaManagers) extends ConfigHandler with Logging { | ||
| def processConfigChanges(brokerId: String, properties: Properties): Unit = { | ||
| if (brokerId == ZooKeeperInternals.DEFAULT_STRING) |
Member
There was a problem hiding this comment.
Please revert those change as this is unrelated to this PR
chia7712
changed the title
Member
|
the |
Contributor
Author
|
I ran the tests locally and passed testVerifyFetchAndAcknowledgeSync() testReplicaManagerFetchShouldProceed() testDelayedInitializationShouldCompleteFetchRequest() testNoMessagesSentExceptionFromOverlappingPatterns() ClientIdQuotaTest |
chia7712
approved these changes
Jan 25, 2025
3 tasks
ijuma
reviewed
Jan 25, 2025
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
chia7712
pushed a commit
that referenced
this pull request
Feb 6, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-18499
Committer Checklist (excluded from commit message)