KAFKA-18591: Remove unused QuotaConfgHandler#18617
Merged
chia7712 merged 1 commit intoapache:trunkfrom Jan 20, 2025
Merged
Conversation
github-actions
Bot
added
triage
frankvicky
changed the title
Member
|
@frankvicky Could you please remove |
frankvicky
force-pushed
the
remove-unused-QuotaConfigHandler
branch
from
8992bcf to
4adbbae
Compare
Contributor
Author
|
Hi @chia7712 |
chia7712
reviewed
Jan 19, 2025
| val props: Properties = new Properties() | ||
| props.put(QuotaConfig.IP_CONNECTION_RATE_OVERRIDE_CONFIG, "1") | ||
|
|
||
| assertThrows(classOf[IllegalArgumentException], () => configHandler.processConfigChanges("illegal-hostname", props)) |
Member
There was a problem hiding this comment.
ClientQuotaMetadataManager#handleIpQuota has similar logic and it seems we don't have unit test for ClientQuotaMetadataManager. Could you please add unit test for it?
frankvicky
force-pushed
the
remove-unused-QuotaConfigHandler
branch
from
4adbbae to
bf7877d
Compare
3 tasks
3 tasks
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
chia7712
pushed a commit
that referenced
this pull request
Feb 6, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-18591
This handler is for zk, we should remove it.
Committer Checklist (excluded from commit message)