MINOR: add the removed topic metrics to zk2kraft#18658
Merged
chia7712 merged 3 commits intoapache:trunkfrom Jan 23, 2025
Merged
MINOR: add the removed topic metrics to zk2kraft#18658chia7712 merged 3 commits intoapache:trunkfrom
chia7712 merged 3 commits intoapache:trunkfrom
Conversation
m1a2st
changed the title
m1a2st
changed the title
# Conflicts: # docs/zk2kraft.html
clolov
reviewed
Jan 22, 2025
Contributor
clolov
left a comment
clolov
left a comment
There was a problem hiding this comment.
Thank you for the addition, this is very useful! I have just a small comment
| Remove the metrics which is monitoring requests waiting in the topic purgatory | ||
| </p> | ||
| <ul> | ||
| <li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li> |
Contributor
There was a problem hiding this comment.
I had a look at the DelayedOperationPurgatory class and I believe you are actually removing 2 metrics instead of one
metricsGroup.newGauge("PurgatorySize", this::watched, metricsTags);
metricsGroup.newGauge("NumDelayedOperations", this::numDelayed, metricsTags);
Could you add this to the description as well?
Collaborator
Author
There was a problem hiding this comment.
Thanks for your review, addressed it.
chia7712
approved these changes
Jan 23, 2025
3 tasks
chia7712
pushed a commit
to chia7712/kafka
that referenced
this pull request
Jan 23, 2025
Reviewers: Christo Lolov <lolovc@amazon.com>, Chia-Ping Tsai <chia7712@gmail.com>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Christo Lolov <lolovc@amazon.com>, Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Christo Lolov <lolovc@amazon.com>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Christo Lolov <lolovc@amazon.com>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see the discussion: https://github.com/apache/kafka/pull/18574/files/89b1137ba0d0978afe796de2aa5110e7718355a0#r1921713711
Committer Checklist (excluded from commit message)