Skip to content

MINOR: add the removed topic metrics to zk2kraft #18658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 3 commits into from
Jan 23, 2025
Merged

MINOR: add the removed topic metrics to zk2kraft #18658

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b354246
wip
m1a2st Jan 21, 2025
e13bf4f
Merge branch 'trunk' into MINOR-METRICS
m1a2st Jan 21, 2025
859c279
addressed by comments
m1a2st Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/zk2kraft.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,5 +176,17 @@ <h5 class="anchor-heading">Removal metrics</h5>
Kafka remove all zookeeper dependencies, so the metrics is removed.
</p>
</li>
<li>
<p>
Remove the metrics which is monitoring requests waiting in the topic purgatory
</p>
<ul>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
Copy link
Copy Markdown
Contributor

@clolov clolov Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the DelayedOperationPurgatory class and I believe you are actually removing 2 metrics instead of one

metricsGroup.newGauge("PurgatorySize", this::watched, metricsTags);
metricsGroup.newGauge("NumDelayedOperations", this::numDelayed, metricsTags);

Could you add this to the description as well?

Copy link
Copy Markdown
Collaborator Author

@m1a2st m1a2st Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, addressed it.

<li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=topic</code></li>
</ul>
<p>
In Kraft mode, Zookeeper is not used, so the metrics is removed.
</p>
</li>
</ul>
</div>