MINOR: fix reassign command bug#20003
Merged
chia7712 merged 2 commits intoapache:trunkfrom Jun 24, 2025
Merged
Conversation
Member
|
@DL1231 could you please add tests for this bug fix? |
chia7712
approved these changes
Jun 24, 2025
chia7712
reviewed
Jun 24, 2025
| } | ||
|
|
||
| // Now cancel the assignment and verify that the partition is removed from cancelled replicas | ||
| assertEquals(new AbstractMap.SimpleImmutableEntry<>(singleton(foo0), Collections.emptySet()), runCancelAssignment(assignment, true, true)); |
Member
There was a problem hiding this comment.
runCancelAssignment returns SimpleImmutableEntry, so you use SimpleImmutableEntry to verify the value, right? If so, that is fine in this PR. However, could you please file a PR to replace SimpleImmutableEntry by Map.entry?
chia7712
pushed a commit
that referenced
this pull request
Jun 24, 2025
see https://github.com/apache/kafka/blob/9570c67b8c4ed1a4c3888511adad58d9b3a8bc0f/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L1208 During the rewrite for [KAFKA-14595](#13247), the relevant condition was omitted. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
chia7712
pushed a commit
that referenced
this pull request
Jun 24, 2025
see https://github.com/apache/kafka/blob/9570c67b8c4ed1a4c3888511adad58d9b3a8bc0f/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L1208 During the rewrite for [KAFKA-14595](#13247), the relevant condition was omitted. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Member
|
backport to 4.1 and 4.0 |
chia7712
pushed a commit
that referenced
this pull request
Jun 26, 2025
see #20003 (comment) Replace `SimpleImmutableEntry` by `Map.entry`. Replace following out-of-date APIs: Arrays.asList Collections.singleton Collections.singletonList Collections.singletonMap Reviewers: Jhen-Yung Hsu <jhenyunghsu@gmail.com>, TengYao Chi <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 2, 2025
see https://github.com/apache/kafka/blob/9570c67b8c4ed1a4c3888511adad58d9b3a8bc0f/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L1208 During the rewrite for [KAFKA-14595](apache#13247), the relevant condition was omitted. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 2, 2025
see apache#20003 (comment) Replace `SimpleImmutableEntry` by `Map.entry`. Replace following out-of-date APIs: Arrays.asList Collections.singleton Collections.singletonList Collections.singletonMap Reviewers: Jhen-Yung Hsu <jhenyunghsu@gmail.com>, TengYao Chi <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 3, 2025
see https://github.com/apache/kafka/blob/9570c67b8c4ed1a4c3888511adad58d9b3a8bc0f/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L1208 During the rewrite for [KAFKA-14595](apache#13247), the relevant condition was omitted. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 3, 2025
see apache#20003 (comment) Replace `SimpleImmutableEntry` by `Map.entry`. Replace following out-of-date APIs: Arrays.asList Collections.singleton Collections.singletonList Collections.singletonMap Reviewers: Jhen-Yung Hsu <jhenyunghsu@gmail.com>, TengYao Chi <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see
kafka/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
Line 1208 in 9570c67
During the rewrite for
KAFKA-14595, the relevant
condition was omitted.
Reviewers: Chia-Ping Tsai chia7712@gmail.com