Skip to content

MINOR: Clean up in ReassignPartitionsCommandTest#20035

Merged
chia7712 merged 6 commits intoapache:trunkfrom
DL1231:ReassignPartitionsCommandTest_cleanup
Jun 26, 2025
Merged

MINOR: Clean up in ReassignPartitionsCommandTest#20035
chia7712 merged 6 commits intoapache:trunkfrom
DL1231:ReassignPartitionsCommandTest_cleanup

Conversation

@DL1231
Copy link
Copy Markdown
Collaborator

@DL1231 DL1231 commented Jun 25, 2025 •
edited by github-actions Bot
Loading

see #20003 (comment)

Replace SimpleImmutableEntry by Map.entry. Replace following
out-of-date APIs:

Arrays.asList      Collections.singleton

Collections.singletonList Collections.singletonMap

Reviewers: Jhen-Yung Hsu jhenyunghsu@gmail.com, TengYao Chi
kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions Bot added triage PRs from the community tools tests Test fixes (including flaky tests) small Small PRs labels Jun 25, 2025
m1a2st
m1a2st reviewed Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DL1231 for this patch, Could you also cleanup following usage?

  • Arrays.asList
  • Collections.singleton
  • Collections.singletonList
  • Collections.singletonMap

@github-actions github-actions Bot removed the triage PRs from the community label Jun 25, 2025
@github-actions github-actions Bot removed the small Small PRs label Jun 25, 2025
Yunyung
Yunyung reviewed Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Yunyung Yunyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Comment thread tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java Outdated
Comment thread tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java Outdated
DL1231 and others added 2 commits June 25, 2025 16:57
@DL1231 @Yunyung
Update tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPa…
34dd095 
…rtitionsCommandTest.java

Co-authored-by: Jhen-Yung Hsu <yungyung7654321@gmail.com>
@DL1231 @Yunyung
Update tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPa…
1ecb504 
…rtitionsCommandTest.java

Co-authored-by: Jhen-Yung Hsu <yungyung7654321@gmail.com>
m1a2st
m1a2st approved these changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@chia7712
Copy link
Copy Markdown
Member

chia7712 commented Jun 25, 2025

@DL1231 could you please cleanup ReassignPartitionsCommand too?

@chia7712 chia7712 merged commit d7745f5 into apache:trunk Jun 26, 2025
23 checks passed
jiafu1115 pushed a commit to jiafu1115/kafka that referenced this pull request Jul 2, 2025
@DL1231
MINOR: Clean up in ReassignPartitionsCommandTest (apache#20035)
c587122 
see apache#20003 (comment)

Replace `SimpleImmutableEntry` by `Map.entry`.  Replace following
out-of-date APIs:

    Arrays.asList      Collections.singleton
Collections.singletonList      Collections.singletonMap

Reviewers: Jhen-Yung Hsu <jhenyunghsu@gmail.com>, TengYao Chi
 <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115 pushed a commit to jiafu1115/kafka that referenced this pull request Jul 3, 2025
@DL1231
MINOR: Clean up in ReassignPartitionsCommandTest (apache#20035)
92db8e6 
see apache#20003 (comment)

Replace `SimpleImmutableEntry` by `Map.entry`.  Replace following
out-of-date APIs:

    Arrays.asList      Collections.singleton
Collections.singletonList      Collections.singletonMap

Reviewers: Jhen-Yung Hsu <jhenyunghsu@gmail.com>, TengYao Chi
 <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankvicky frankvicky frankvicky approved these changes

+2 more reviewers

@Yunyung Yunyung Yunyung approved these changes

@m1a2st m1a2st m1a2st approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-approved tests Test fixes (including flaky tests) tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DL1231 @chia7712 @Yunyung @frankvicky @m1a2st