KAFKA-2504: Stop logging WARN when client disconnects#211
Closed
jholoman wants to merge 2 commits intoapache:trunkfrom
jholoman:KAFKA-2504
Closed
KAFKA-2504: Stop logging WARN when client disconnects#211jholoman wants to merge 2 commits intoapache:trunkfrom jholoman:KAFKA-2504
jholoman wants to merge 2 commits intoapache:trunkfrom
jholoman:KAFKA-2504
Conversation
|
kafka-trunk-git-pr #421 SUCCESS |
Contributor
There was a problem hiding this comment.
Does it still make sense to have the if/else here? we log debug anyway and the exception should contain enough information to figure out the type of error.
|
kafka-trunk-git-pr #424 SUCCESS |
omkreddy
added a commit
to omkreddy/kafka
that referenced
this pull request
Aug 3, 2019
This reverts the changes done in: confluentinc@e5a6ed3
omkreddy
added a commit
to omkreddy/kafka
that referenced
this pull request
Jan 7, 2020
This reverts the changes done in: confluentinc@e5a6ed3
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
xiowu0
pushed a commit
to xiowu0/kafka
that referenced
this pull request
Dec 9, 2021
TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper.
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 16, 2022
This is a squash of 2 commits in 2.4-li - 7820050 [LI-HOTFIX] Add the move controller RPC (apache#211) - 8c0345a [LI-HOTFIX] Fixing the broken tests in RequestQuotaTest caused by the new moveController API (apache#212) TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper. Co-authored-by: Lucas Wang <luwang@linkedin.com>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
This is a squash of 2 commits in 2.4-li - 7820050 [LI-HOTFIX] Add the move controller RPC (apache#211) - 8c0345a [LI-HOTFIX] Fixing the broken tests in RequestQuotaTest caused by the new moveController API (apache#212) TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper. Co-authored-by: Lucas Wang <luwang@linkedin.com>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
This is a squash of 2 commits in 2.4-li - 7820050 [LI-HOTFIX] Add the move controller RPC (apache#211) - 8c0345a [LI-HOTFIX] Fixing the broken tests in RequestQuotaTest caused by the new moveController API (apache#212) TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper. Co-authored-by: Lucas Wang <luwang@linkedin.com>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
…#211) Instead of duplicating test setup classes, extend the existing ones, and use junit tags to pass the flag to enable inkless (at the class or method level), and pass the containers to the utils to create broker configs.
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
Signed-off-by: Greg Harris <greg.harris@aiven.io>
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
…#211) Instead of duplicating test setup classes, extend the existing ones, and use junit tags to pass the flag to enable inkless (at the class or method level), and pass the containers to the utils to create broker configs.
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Greg Harris <greg.harris@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.