KAFKA-2300: Error in controller log when broker tries to rejoin cluster#212
Closed
fpj wants to merge 11 commits intoapache:trunkfrom
Closed
KAFKA-2300: Error in controller log when broker tries to rejoin cluster#212fpj wants to merge 11 commits intoapache:trunkfrom
fpj wants to merge 11 commits intoapache:trunkfrom
Conversation
…atch and fixed string typo.
Contributor
There was a problem hiding this comment.
nit: both clear() and resign() have side effects, so we need the parentheses.
Other than this, LGTM.
|
kafka-trunk-git-pr #423 SUCCESS |
|
kafka-trunk-git-pr #451 SUCCESS |
|
kafka-trunk-git-pr #453 FAILURE |
Contributor
Author
|
Test failure is unrelated to the latest change (I have only added parentheses): |
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Aug 3, 2019
This stopped working when we migrated this code to Gradle in the
`confluentinc/kafka` repository. Previously, the version.properties
file was populated by `Maven`. Rely on post-processing of the kafka
version instead.
Without this change, the basic collector is basically broken as the
server will reject messages that have `${project.version}` as the
version.
Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
jsancio
pushed a commit
to jsancio/kafka
that referenced
this pull request
Aug 6, 2019
…pache#212) Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Jan 7, 2020
This stopped working when we migrated this code to Gradle in the
`confluentinc/kafka` repository. Previously, the version.properties
file was populated by `Maven`. Rely on post-processing of the kafka
version instead.
Without this change, the basic collector is basically broken as the
server will reject messages that have `${project.version}` as the
version.
Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
Allow entities that has more than the required valid windows to be included in the aggregation, even if they have more than the max allowed extrapolations.
xiowu0
pushed a commit
to xiowu0/kafka
that referenced
this pull request
Dec 9, 2021
… new moveController API (apache#212) TICKET = N/A LI_DESCRIPTION = Recently we added the moveController API to the KafkaAdminClient, which caused some tests in the RequestQuotaTest to fail. This PR fixes the broken tests by recognizing the new LI_MOVE_CONTROLLER API key. EXIT_CRITERIA = this change has the same exit criteria as the original PR that addes the moveController API.
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 16, 2022
This is a squash of 2 commits in 2.4-li - 7820050 [LI-HOTFIX] Add the move controller RPC (apache#211) - 8c0345a [LI-HOTFIX] Fixing the broken tests in RequestQuotaTest caused by the new moveController API (apache#212) TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper. Co-authored-by: Lucas Wang <luwang@linkedin.com>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
This is a squash of 2 commits in 2.4-li - 7820050 [LI-HOTFIX] Add the move controller RPC (apache#211) - 8c0345a [LI-HOTFIX] Fixing the broken tests in RequestQuotaTest caused by the new moveController API (apache#212) TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper. Co-authored-by: Lucas Wang <luwang@linkedin.com>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
This is a squash of 2 commits in 2.4-li - 7820050 [LI-HOTFIX] Add the move controller RPC (apache#211) - 8c0345a [LI-HOTFIX] Fixing the broken tests in RequestQuotaTest caused by the new moveController API (apache#212) TICKET = LIKAFKA-37769 LI_DESCRIPTION = In order to make Kafka SOX compliant, all of the znodes need to be protected with ACLS and become writable only by kafka-server. This means the ktool cluster move-controller command will be rejected. To continue supporting the ktool command above, this PR adds a new moveController API to the KafkaAdminClient. EXIT_CRITERIA = We can deprecate this PR if either of the following two conditions is met 1. this change is merged in upstream 2. a new equivalent API is added upstream that works based on the Raft-based controller quorum, and we are deprecating zookeeper. Co-authored-by: Lucas Wang <luwang@linkedin.com>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
* INK-142: GCS support * chore: splitting the docker compose file
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
* INK-142: GCS support * chore: splitting the docker compose file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have reopened this issue because the controller isn't cleaning up the state upon an exception and the test case was legitimately failing for me every now and then. I'm proposing a change to fix this.