KAFKA-2624: Change log message position#287
Closed
dopuskh3 wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
Log warning message before truncating log in order to display right offset value for the truncated log.
Member
|
Thanks. LGTM |
Contributor
Author
|
Hi, Can we close this MR ? Thanks |
Member
|
@dopuskh3 Maybe you can ping a reviewer directly to review the patch. |
Contributor
|
Thanks for the patch. LGTM |
asfgit
pushed a commit
that referenced
this pull request
Nov 14, 2015
Log warning message before truncating log in order to display right offset value for the truncated log. Author: Francois Visconte <f.visconte@criteo.com> Reviewers: Dong Lin <lindong28@gmail.com>, Jun Rao <junrao@gmail.com> Closes #287 from dopuskh3/KAFKA-2624 (cherry picked from commit 356544c) Signed-off-by: Jun Rao <junrao@gmail.com>
granders
referenced
this pull request
in confluentinc/kafka
Nov 18, 2015
Log warning message before truncating log in order to display right offset value for the truncated log. Author: Francois Visconte <f.visconte@criteo.com> Reviewers: Dong Lin <lindong28@gmail.com>, Jun Rao <junrao@gmail.com> Closes #287 from dopuskh3/KAFKA-2624
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
TICKET = KAFKA-7186 LI_DESCERIPTION = This is a rewrite of the original PR apache#75. In kafka 3.0, structs are removed, and requests can be serialized directly into ByteBuffers. In vanilla kafka, the header and body are serialized directly into a single ByteBuffer inside the SendBuilder. However, to reduce the memory footprint of UMRs, we would still want the ByteBufferSends destined to different brokers to share the same body ByteBuffer. To achieve that, this PR modifies the Java code generator so that the generated UpdateMetadataRequestData has the following implementation for its write method ` private final ReentrantLock bodyBufferLock = new ReentrantLock(); private ByteBuffer bodyBuffer = null; @OverRide public void write(Writable _writable, ObjectSerializationCache _cache, short _version) { bodyBufferLock.lock(); try{ if (bodyBuffer == null) { ObjectSerializationCache serializationCache = new ObjectSerializationCache(); MessageSizeAccumulator messageSize = new MessageSizeAccumulator(); addSize(messageSize, serializationCache, _version); bodyBuffer = ByteBuffer.allocate(messageSize.totalSize()); doWrite(new ByteBufferAccessor(bodyBuffer), _cache, _version); bodyBuffer.flip(); } } finally { bodyBufferLock.unlock(); } _writable.writeByteBuffer(bodyBuffer); } ` All other types of requests would end up with a write implementation as follows, which is essentially the same as the vanilla implementation. ` @OverRide public void write(Writable _writable, ObjectSerializationCache _cache, short _version) { doWrite(_writable, _cache, _version); } ` EXIT_CRITERIA = KAFKA-7186
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
TICKET = KAFKA-7186 LI_DESCERIPTION = This is a rewrite of the original PR apache#75. In kafka 3.0, structs are removed, and requests can be serialized directly into ByteBuffers. In vanilla kafka, the header and body are serialized directly into a single ByteBuffer inside the SendBuilder. However, to reduce the memory footprint of UMRs, we would still want the ByteBufferSends destined to different brokers to share the same body ByteBuffer. To achieve that, this PR modifies the Java code generator so that the generated UpdateMetadataRequestData has the following implementation for its write method ` private final ReentrantLock bodyBufferLock = new ReentrantLock(); private ByteBuffer bodyBuffer = null; @OverRide public void write(Writable _writable, ObjectSerializationCache _cache, short _version) { bodyBufferLock.lock(); try{ if (bodyBuffer == null) { ObjectSerializationCache serializationCache = new ObjectSerializationCache(); MessageSizeAccumulator messageSize = new MessageSizeAccumulator(); addSize(messageSize, serializationCache, _version); bodyBuffer = ByteBuffer.allocate(messageSize.totalSize()); doWrite(new ByteBufferAccessor(bodyBuffer), _cache, _version); bodyBuffer.flip(); } } finally { bodyBufferLock.unlock(); } _writable.writeByteBuffer(bodyBuffer); } ` All other types of requests would end up with a write implementation as follows, which is essentially the same as the vanilla implementation. ` @OverRide public void write(Writable _writable, ObjectSerializationCache _cache, short _version) { doWrite(_writable, _cache, _version); } ` EXIT_CRITERIA = KAFKA-7186
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
TICKET = KAFKA-7186 LI_DESCERIPTION = This is a rewrite of the original PR apache#75. In kafka 3.0, structs are removed, and requests can be serialized directly into ByteBuffers. In vanilla kafka, the header and body are serialized directly into a single ByteBuffer inside the SendBuilder. However, to reduce the memory footprint of UMRs, we would still want the ByteBufferSends destined to different brokers to share the same body ByteBuffer. To achieve that, this PR modifies the Java code generator so that the generated UpdateMetadataRequestData has the following implementation for its write method ` private final ReentrantLock bodyBufferLock = new ReentrantLock(); private ByteBuffer bodyBuffer = null; @OverRide public void write(Writable _writable, ObjectSerializationCache _cache, short _version) { bodyBufferLock.lock(); try{ if (bodyBuffer == null) { ObjectSerializationCache serializationCache = new ObjectSerializationCache(); MessageSizeAccumulator messageSize = new MessageSizeAccumulator(); addSize(messageSize, serializationCache, _version); bodyBuffer = ByteBuffer.allocate(messageSize.totalSize()); doWrite(new ByteBufferAccessor(bodyBuffer), _cache, _version); bodyBuffer.flip(); } } finally { bodyBufferLock.unlock(); } _writable.writeByteBuffer(bodyBuffer); } ` All other types of requests would end up with a write implementation as follows, which is essentially the same as the vanilla implementation. ` @OverRide public void write(Writable _writable, ObjectSerializationCache _cache, short _version) { doWrite(_writable, _cache, _version); } ` EXIT_CRITERIA = KAFKA-7186
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log warning message before truncating log in order to
display right offset value for the truncated log.