KAFKA-2487: change kafka.examples.Consumer to use the new java consumer#297
Closed
SinghAsDev wants to merge 2 commits intoapache:trunkfrom
Closed
KAFKA-2487: change kafka.examples.Consumer to use the new java consumer#297SinghAsDev wants to merge 2 commits intoapache:trunkfrom
SinghAsDev wants to merge 2 commits intoapache:trunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Could we use ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG etc instead of hand-coded strings? It is less error-prone for possible future changes.
Contributor
Author
There was a problem hiding this comment.
True. Addressed.
Contributor
|
Thanks for the patch. The Jekins failures are not related. Overall looks good, left some minor comments. |
added 2 commits
October 15, 2015 15:16
…ad. 2. Use conf name consts from ConsumerConfig
SinghAsDev
force-pushed
the
KAFKA-2487
branch
from
97fbdc7 to
f6ea3c7
Compare
Contributor
Author
|
@guozhangwang thanks for the review. Addressed your concerns. |
Contributor
There was a problem hiding this comment.
This is because we are inheriting a Scala class, and moving forward we should remove this with the Java version
org.apache.kafka.copycat.util.ShutdownableThread that can be moved into o.a.k.common.utils.
We can leave it as is for now.
Contributor
|
LGTM. The Jenkins failures seem not related. |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
steverod
pushed a commit
to steverod/kafka
that referenced
this pull request
Apr 27, 2020
Reviewer: lucas@confluent.io
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Reviewer: lucas@confluent.io
wyuka
added a commit
to wyuka/kafka
that referenced
this pull request
Mar 10, 2022
* [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (apache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>
wyuka
added a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
Cherry picked commit: * [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (apache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>
wyuka
added a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
Cherry picked commit: * [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (apache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
Start time is measured on initialization which has wrong values: when an active file is initialized at the startup (leading to very large initial start time); and similarly if there is a period of no writes, the last rotation will start the counter at a very far time. To measure this correctly, only initialize on the first add to the batch.
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
Start time is measured on initialization which has wrong values: when an active file is initialized at the startup (leading to very large initial start time); and similarly if there is a period of no writes, the last rotation will start the counter at a very far time. To measure this correctly, only initialize on the first add to the batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.