add support libvirt as provider. KAFKA-2183 by pronix · Pull Request #62 · apache/kafka

pronix · 2015-05-10T20:07:59Z

https://issues.apache.org/jira/browse/KAFKA-2183

ewencp · 2015-05-11T00:58:10Z

These all appear to be spacing changes, can we clear these out of the diff?

pronix · 2015-05-11T05:30:17Z

should i squash commits right now ?

ewencp · 2015-05-11T05:35:39Z

Not sure about squashing commits, using Github PRs is new for Kafka. I think that happens as part of the commit process, which is not managed through Github. You'll need a committer to approve this anyway, I'm just reviewing since I helped with the Vagrantfile previously. I think @nehanarkhede was shepherding the new Github PR approach and might know the process better.

pronix · 2015-05-14T08:15:56Z

any news ?

ijuma · 2015-07-20T14:23:15Z

The proposed documentation for the GitHub-based process (it's not official yet):

https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

Regarding squashing of commits, it depends on whether it's useful to have separate commits or not (i.e. does each commit represent a self-contained change that makes sense on its own, compiles and passes the tests?).

The merge script will squash the commits into one, but it will also include a reference to each individual commit. As such, commits that don't add any value should be squashed before the merge step.

pronix · 2015-08-25T14:20:58Z

squashed

asfbot · 2015-08-25T15:11:15Z

kafka-trunk-git-pr #215 FAILURE
Looks like there's a problem with this pull request

ewencp · 2015-08-27T23:46:47Z

This updated version looks good to me, but I don't have a linux box handy to test on and don't think I have anything to test on that would support nested virtualization.

pronix · 2015-08-28T05:23:49Z

It is mainly for avoid virtualbox on linux. And libvirt supported on macos
as client.
On 28 Aug 2015 01:47, "Ewen Cheslack-Postava" notifications@github.com
wrote:

This updated version looks good to me, but I don't have a linux box handy
to test on and don't think I have anything to test on that would support
nested virtualization.

—
Reply to this email directly or view it on GitHub
#62 (comment).

Pull latest commits from apache trunk to merge in streaming.

ewencp · 2015-10-04T22:29:52Z

I noticed the shebang line is in the wrong place, both here and in the other scripts in vagrant/. Wouldn't hurt to clean that up in this patch even though it wasn't introduced here. It looks like we're currently relying on bash being the default shell in the VMs because of this error.

ewencp · 2015-10-04T22:32:38Z

@pronix Sorry for the slow follow up. I was never able to test this with libvirt on OS X. I think the vagrant-libvirt plugin doesn't support the vbox support in libvirt, so it's not easy to test there -- only on platforms where qemu or kvm are usable.

I have a Linux box handy now that I can test on. The current patch had a few minor problems under that environment (Ubuntu trusty box with KVM, Vagrant 1.7.4). But once I cleaned up the bash scripts under vagrant/ a bit, things worked ok, including the vagrant/zk.sh and vagrant/broker.sh scripts. If we update the patch, I'll test once more, but I think this will be ready to merge.

[LOGBROKER-1780] NoSuchElementException fixed

guozhangwang · 2016-12-21T02:09:05Z

@pronix Could you reply Ewen's comments so we can proceed the review process?

asfbot · 2016-12-21T02:51:31Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/302/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2016-12-21T02:53:18Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/303/
Test FAILed (JDK 8 and Scala 2.11).

asfbot · 2016-12-21T03:57:10Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/301/
Test PASSed (JDK 7 and Scala 2.10).

jeqo · 2017-01-19T18:53:10Z

I'd like to help with this issue.

I've test @pronix branch and looks like the box his referencing (http://citozin.com/fedora21.box) is not available. I would recommend to use a box that is already hosted in Atlas (Official Vagrant Box registry) https://atlas.hashicorp.com/

I've tested with this box: https://atlas.hashicorp.com/yk0/boxes/ubuntu-xenial.

With this box we don't need to have scripts fedora and ubuntu distributions.

Take a look to this commit: jeqo@ff2f58d

asfbot · 2017-01-19T19:41:39Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1032/
Test PASSed (JDK 8 and Scala 2.12).

asfbot · 2017-01-19T19:42:42Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1034/
Test PASSed (JDK 8 and Scala 2.11).

asfbot · 2017-01-19T20:15:35Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1032/
Test PASSed (JDK 7 and Scala 2.10).

guozhangwang · 2017-01-19T21:03:31Z

cc @ewencp

ewencp · 2017-06-04T04:21:41Z

@jeqo Is there an official ubuntu box that we can reference? It doesn't seem great to have references to individual user vagrant boxes rather than an official project image.

asfbot · 2017-06-04T04:22:50Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/4861/
Test FAILed (JDK 8 and Scala 2.12).

asfbot · 2017-06-04T04:22:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/4877/
Test FAILed (JDK 7 and Scala 2.11).

jeqo · 2017-06-21T12:33:09Z

@ewencp yes, I agree but I cannot find any official Ubuntu image in Vagrant Atlas.
At least I see that this one is used also by Kubernetes Vagrant/Ansible config: https://github.com/kubernetes/contrib/blob/master/ansible/vagrant/Vagrantfile#L98

I give a try to vagrant-mutate to migrate a VirtualBox to Libvirt as is commented here: https://jira.mesosphere.com/browse/DCOS_VAGRANT-10 but is not working, I get an issue with SSH access that haven't manage to fix yet.

asfgit · 2017-06-21T12:33:58Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5547/
Test FAILed (JDK 8 and Scala 2.12).

asfgit · 2017-06-21T12:34:57Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5561/
Test FAILed (JDK 7 and Scala 2.11).

…pache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""]

vvcephei · 2022-02-09T19:34:49Z

Hi @pronix ,

It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new one)!

Thanks,
John

…pache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""]

* [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (apache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>

Cherry picked commit: * [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (apache#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>

…apache#62) 0. Address comments from P1. 1. Add the DefaultTaskExecutor implementation class. 2. Related DefaultTaskExecutorTest. Pending in future PRs: a) exception handling, primarily to send them to polling thread, b) light-weight task flushing procedure. Co-authored-by: Guozhang Wang <wangguoz@gmail.com>

add state machine

…apache#3) Remediates 3 MINOR QA findings — all broken anchor fragments in docs/security-audit/findings/07-external-function-callback-misuse.md. The previous anchor fragments used MkDocs-style semantic IDs that do not resolve against GitHub-flavored markdown auto-generated heading slugs. This commit aligns each fragment to the GitHub-computed slug for the target heading. Fixes: * Line 197: #oauth -> apache#32-security--oauth Target: ### 3.2 Security - OAuth (accepted-mitigations.md:201) (double-hyphen comes from the two spaces around the em-dash; the em-dash itself is stripped by the GitHub slug algorithm) * Line 227: #oauth -> apache#32-security--oauth (both visible text and URL) Target: same as Line 197 (second occurrence in the 'Cross-References' section) * Line 232: apache#62-restclient-forwarding -> apache#42-connect-restclient- forwards-the-inbound-authorization-header-to-outbound-worker- peer-calls-062 Target: ### 4.2 Connect RestClient forwards the inbound Authorization header to outbound worker-peer calls (06.2) (findings/06-network-subprocess-access.md:90) (URL fragment updated; visible short identifier retained for readability per QA suggested-fix guidance) Validation: * Runtime re-verification: all 88 anchor-bearing links across the 24 audit markdown files now resolve (0 broken anchors). * File inventory unchanged: 25 files, surgical 6-line diff (3 insertions, 3 deletions). * Visual Architecture Documentation rule preserved: all 7 diagrams still referenced by name across findings and supporting docs. * Audit Only rule preserved: zero source-code modifications; only the audit deliverable under docs/security-audit/ is touched. QA report: QA Final Checkpoint apache#3 - Link Integrity + Cross-References + License Headers (Issues 1-3, all MINOR, all in findings/07).

ewencp reviewed May 11, 2015
View reviewed changes

Comment thread README.md Outdated

Copy link
Copy Markdown

Contributor

ewencp May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all appear to be spacing changes, can we clear these out of the diff?

add support libvirt as provider

8f59a82

pronix force-pushed the add_libvirt_support branch from 80ef4b0 to 8f59a82 Compare August 25, 2015 14:20

rhauch pushed a commit to rhauch/kafka that referenced this pull request Sep 21, 2015

Merge pull request apache#62 from guozhangwang/rebaseApache

ec8bd8a

Pull latest commits from apache trunk to merge in streaming.

ewencp reviewed Oct 4, 2015
View reviewed changes

resetius added a commit to resetius/kafka that referenced this pull request Aug 14, 2016

Merge pull request apache#62 from aozeritsky/0.9.0-stbx

050f825

[LOGBROKER-1780] NoSuchElementException fixed

asfgit force-pushed the trunk branch from 1cd01ad to 619fd7a Compare May 3, 2017 00:18

efeg added a commit to efeg/kafka that referenced this pull request Jan 29, 2020

Fix minor typo in AnalyzerState. (apache#62)

0a799c1

vvcephei closed this Feb 9, 2022

fvaleri pushed a commit to fvaleri/kafka that referenced this pull request Jan 23, 2026

Merge pull request apache#62 from showuon/cl3_state

002c28a

add state machine

Conversation

pronix commented May 10, 2015

Uh oh!

ewencp May 11, 2015

Choose a reason for hiding this comment

Uh oh!

pronix commented May 11, 2015

Uh oh!

ewencp commented May 11, 2015

Uh oh!

pronix commented May 14, 2015

Uh oh!

ijuma commented Jul 20, 2015

Uh oh!

pronix commented Aug 25, 2015

Uh oh!

asfbot commented Aug 25, 2015

Uh oh!

ewencp commented Aug 27, 2015

Uh oh!

pronix commented Aug 28, 2015

Uh oh!

ewencp Oct 4, 2015

Choose a reason for hiding this comment

Uh oh!

ewencp commented Oct 4, 2015

Uh oh!

guozhangwang commented Dec 21, 2016

Uh oh!

asfbot commented Dec 21, 2016

Uh oh!

asfbot commented Dec 21, 2016

Uh oh!

asfbot commented Dec 21, 2016

Uh oh!

jeqo commented Jan 19, 2017

Uh oh!

asfbot commented Jan 19, 2017

Uh oh!

asfbot commented Jan 19, 2017

Uh oh!

asfbot commented Jan 19, 2017

Uh oh!

guozhangwang commented Jan 19, 2017

Uh oh!

ewencp commented Jun 4, 2017

Uh oh!

asfbot commented Jun 4, 2017

Uh oh!

asfbot commented Jun 4, 2017

Uh oh!

jeqo commented Jun 21, 2017

Uh oh!

asfgit commented Jun 21, 2017

Uh oh!

asfgit commented Jun 21, 2017

Uh oh!

vvcephei commented Feb 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants