Skip to content

[kafka-1828]add judgement for ConsumerPerformance against negative number#38

Closed
maji2014 wants to merge 1 commit intoapache:trunkfrom
maji2014:kafka-1828
Closed

[kafka-1828]add judgement for ConsumerPerformance against negative number#38
maji2014 wants to merge 1 commit intoapache:trunkfrom
maji2014:kafka-1828

Conversation

@maji2014
Copy link
Copy Markdown

@maji2014 maji2014 commented Dec 24, 2014

The result is negative number when runnning a short time for consumer performance testing, but user doesn't the reason, so add judgement for this, and then according to the reason, user can do ConsumerPerformance.

negative result like:
start.time, end.time, fetch.size, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec
2014-12-23 19:32:39:120, 2014-12-23 19:32:39:152, 1048576, 0.0790, -0.1689, 1000, -2136.7521

anybody, could you help to check this?

@maji2014 maji2014 changed the title add judgement for ConsumerPerformance against negative number [kafka-1828]add judgement for ConsumerPerformance against negative number Dec 24, 2014
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 20, 2015

This pull request doesn't merge cleanly anymore, can you please close it?

Sorry for not replying to this earlier, but pull requests are not currently monitored as the Kafka project uses JIRA and Review Board for contributions. There is a plan to change this and we would like to close stale PRs before we start. Unfortunately we can't do it ourselves (a JIRA needs to be filed with Apache Infra) so your help is appreciated.

If this change is still relevant, please see http://kafka.apache.org/contributing.html. Alternatively wait until the new approach based on GitHub pull requests is in place (hopefully soon).

ymatsuda referenced this pull request in confluentinc/kafka Aug 5, 2015
@ymatsuda
Merge pull request #38 from ymatsuda/rename_WindowByTime_to_SlidingWi…
3e05897 
…ndow

renamed WindowByTime to SlidingWindow
@maji2014 maji2014 closed this Jan 13, 2016
resetius added a commit to resetius/kafka that referenced this pull request Apr 22, 2016
@resetius
Merge pull request apache#38 from aozeritsky/0.9.0-stbx
e1ef3c1 
0.9.0 stbx
xiowu0 added a commit to xiowu0/kafka that referenced this pull request Aug 28, 2019
@xiowu0
[LI-HOTFIX] add prepare-commit-msg hook to help format commit message (…
d902f8d 
…apache#38)

TICKET =
LI_DESCRIPTION =
Automatically reformat commit messages via git hook:
  1) extract ticket number and reformat for cherry-picks
  2) provide a standard template for Hotfix patches.

Setup/Install the hook:
  .githooks/setup.sh
Remove the hook:
  .githooks/uninstall.sh

Once installed, the hook will be automatically invoked through the following usages:
  cherry-pick (please use -x):
    git cherry-pick -e <hash> -x

  Hotfix:
    git commit ...
EXIT_CRITERIA = MANUAL [""]
smccauliff pushed a commit to smccauliff/kafka that referenced this pull request Oct 8, 2020
@xiowu0 @gitlw
[LI-HOTFIX] add prepare-commit-msg hook to help format commit message (…
392e32f 
…apache#38)

TICKET =
LI_DESCRIPTION =
Automatically reformat commit messages via git hook:
  1) extract ticket number and reformat for cherry-picks
  2) provide a standard template for Hotfix patches.

Setup/Install the hook:
  .githooks/setup.sh
Remove the hook:
  .githooks/uninstall.sh

Once installed, the hook will be automatically invoked through the following usages:
  cherry-pick (please use -x):
    git cherry-pick -e <hash> -x

  Hotfix:
    git commit ...
EXIT_CRITERIA = MANUAL [""]
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jan 7, 2022
@xiowu0 @lmr3796
[LI-HOTFIX] CI: Add prepare-commit-msg hook to help format commit mes…
421b3bd 
…sage (apache#38)

TICKET =
LI_DESCRIPTION =
Automatically reformat commit messages via git hook:
  1) extract ticket number and reformat for cherry-picks
  2) provide a standard template for Hotfix patches.

Setup/Install the hook:
  .githooks/setup.sh
Remove the hook:
  .githooks/uninstall.sh

Once installed, the hook will be automatically invoked through the following usages:
  cherry-pick (please use -x):
    git cherry-pick -e <hash> -x

  Hotfix:
    git commit ...
EXIT_CRITERIA = MANUAL [""]
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 4, 2022
@xiowu0 @lmr3796
[LI-HOTFIX] CI: Add prepare-commit-msg hook to help format commit mes…
373739a 
…sage (apache#38)

TICKET =
LI_DESCRIPTION =
Automatically reformat commit messages via git hook:
  1) extract ticket number and reformat for cherry-picks
  2) provide a standard template for Hotfix patches.

Setup/Install the hook:
  .githooks/setup.sh
Remove the hook:
  .githooks/uninstall.sh

Once installed, the hook will be automatically invoked through the following usages:
  cherry-pick (please use -x):
    git cherry-pick -e <hash> -x

  Hotfix:
    git commit ...
EXIT_CRITERIA = MANUAL [""]
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 28, 2022
@xiowu0 @lmr3796
[LI-HOTFIX] CI: Add prepare-commit-msg hook to help format commit mes…
13a13f0 
…sage (apache#38)

TICKET =
LI_DESCRIPTION =
Automatically reformat commit messages via git hook:
  1) extract ticket number and reformat for cherry-picks
  2) provide a standard template for Hotfix patches.

Setup/Install the hook:
  .githooks/setup.sh
Remove the hook:
  .githooks/uninstall.sh

Once installed, the hook will be automatically invoked through the following usages:
  cherry-pick (please use -x):
    git cherry-pick -e <hash> -x

  Hotfix:
    git commit ...
EXIT_CRITERIA = MANUAL [""]
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jun 16, 2022
@xiowu0 @lmr3796
[LI-HOTFIX] CI: Add prepare-commit-msg hook to help format commit mes…
f700637 
…sage (apache#38)

TICKET =
LI_DESCRIPTION =
Automatically reformat commit messages via git hook:
  1) extract ticket number and reformat for cherry-picks
  2) provide a standard template for Hotfix patches.

Setup/Install the hook:
  .githooks/setup.sh
Remove the hook:
  .githooks/uninstall.sh

Once installed, the hook will be automatically invoked through the following usages:
  cherry-pick (please use -x):
    git cherry-pick -e <hash> -x

  Hotfix:
    git commit ...
EXIT_CRITERIA = MANUAL [""]
divijvaidya added a commit to divijvaidya/kafka that referenced this pull request Jan 24, 2023
@divijvaidya
Fix bug when replica is synced with incorrect (Global)logStartOffset (a…
95885bd 
…pache#38)

* Fix bug in setting ReplicaLogStartOffset when LeaderLogStartOffset is different from LeaderLocalLogStartOffset
lianetm added a commit to lianetm/kafka that referenced this pull request Aug 8, 2023
@lianetm
KAFKA-15306 - Integrate refreshOffsets logic for fetching (apache#38)
404916d
rustd pushed a commit to rustd/pranavfinaldemokafka that referenced this pull request Feb 9, 2024
@rutvijmehta-harness @akatona84
MINOR: Add shebang to gradlewAll (apache#11373) (apache#38)
eb83300 
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>

Co-authored-by: Andras Katona <41361962+akatona84@users.noreply.github.com>
patrik-marton pushed a commit to patrik-marton/kafka that referenced this pull request Mar 11, 2025
@david-simon
CSMDS-162: Set ZK version to latest released CDP version
bdf09f9 
CSMDS-219: Upgrade ZK (apache#26)

becaue of CVE-2023-44981

Zk upgrade and version moved to properties for replacement (apache#32)

CSMDS-483: Bump ZK version to 3.8.1.7.2.18.0-641 (apache#38)

CSMDS-561: Update ZK to 3.8.1.7.2.18.200-37 (apache#77)
fvaleri pushed a commit to fvaleri/kafka that referenced this pull request Dec 19, 2025
@showuon
Merge pull request apache#38 from fvaleri/add-tool
7e1138b 
Add kafka-mirrors.sh tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maji2014 @ijuma