KAFKA-5520: KIP-171 - Extend Consumer Group Reset Offset for Stream Application#3831
KAFKA-5520: KIP-171 - Extend Consumer Group Reset Offset for Stream Application#3831jeqo wants to merge 13 commits intoapache:trunkfrom
Conversation
support topics and partitions.
| .describedAs("id") | ||
| .required(); | ||
| bootstrapServerOption = optionParser.accepts("bootstrap-servers", "Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") | ||
| bootstrapServerOption = optionParser.accepts("bootstrap-server", "Comma-separated list of broker urls with format: HOST1:PORT1,HOST2:PORT2") |
There was a problem hiding this comment.
Why removing the trailing 's' ?
There was a problem hiding this comment.
Forgot to mention it on the KIP, was thinking about aligning options. In Consumer Group command, and other, the option is bootstrap-server. Should I rollback this change?
There was a problem hiding this comment.
If it is not in KIP, better roll back.
There was a problem hiding this comment.
yeap, pushing changes.
|
@jeqo Thanks for the PR. The KIP is not accepted yet, and there is no vote started. As a vote need to be open for 72h and KIPs must be accepted by tomorrow to be considered for 1.0 release, this will not make it anymore and we need to move it for 1.1 release. \cc @guozhangwang Please correct me if I am wrong. Thus, I would first try to get the KIP voted, and we can review this afterwards. |
|
There is a VOTE thread started already by @jeqo . I think implementation in parallel while waiting for the KIP to be accepted is ok. |
|
Closing this PR to merge with KIP-198: #4159 |
|
I'm not sure if we want to do these two KIPs in the same PR, but rather KIP-171 would depend on KIP-198 being done along which we will add the listTopics in the admin client. But that's just my understanding. @mjsax could you clarify? |
|
I agree. We should have 2 PR per KIP/JIRA. |
|
But KIP-198 is already merged https://cwiki.apache.org/confluence/display/KAFKA/KIP-198%3A+Remove+ZK+dependency+from+Streams+Reset+Tool :) |
…plication KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-171+-+Extend+Consumer+Group+Reset+Offset+for+Stream+Application Merge changes from KIP-198 Ref: #3831 Author: Jorge Quilcate Otoya <quilcate.jorge@gmail.com> Author: Ismael Juma <ismael@juma.me.uk> Author: Matthias J. Sax <matthias@confluent.io> Author: Manikumar Reddy <manikumar.reddy@gmail.com> Author: Guozhang Wang <wangguoz@gmail.com> Author: Apurva Mehta <apurva@confluent.io> Author: Rajini Sivaram <rajinisivaram@googlemail.com> Author: Jason Gustafson <jason@confluent.io> Author: Vahid Hashemian <vahidhashemian@us.ibm.com> Author: Bill Bejeck <bill@confluent.io> Author: Dong Lin <lindong28@gmail.com> Author: Soenke Liebau <soenke.liebau@opencore.com> Author: Colin P. Mccabe <cmccabe@confluent.io> Author: Damian Guy <damian.guy@gmail.com> Author: Xavier Léauté <xl+github@xvrl.net> Author: Maytee Chinavanichkit <maytee.chinavanichkit@linecorp.com> Author: Joel Hamill <git config --global user.email> Author: Paolo Patierno <ppatierno@live.com> Author: siva santhalingam <siva.santhalingam@gmail.com> Author: Tommy Becker <tobecker@tivo.com> Author: Mickael Maison <mickael.maison@gmail.com> Author: Onur Karaman <okaraman@linkedin.com> Author: tedyu <yuzhihong@gmail.com> Author: Xin Li <Xin.Li@trivago.com> Author: Magnus Edenhill <magnus@edenhill.se> Author: Manjula K <manjula@kafka-summit.org> Author: Hugo Louro <hmclouro@gmail.com> Author: Jeff Widman <jeff@jeffwidman.com> Author: bartdevylder <bartdevylder@gmail.com> Author: Ewen Cheslack-Postava <me@ewencp.org> Author: Jacek Laskowski <jacek@japila.pl> Author: Tom Bentley <tbentley@redhat.com> Author: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com> Closes #4159 from jeqo/feature/kip-171
4 participants
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-171+-+Extend+Consumer+Group+Reset+Offset+for+Stream+Application