Skip to content

KAFKA-9225: Bump rocksdb 5.18.3 to 5.18.4#8284

Merged
mjsax merged 1 commit intoapache:trunkfrom
jiameixie:rocksdb
Mar 19, 2020
Merged

KAFKA-9225: Bump rocksdb 5.18.3 to 5.18.4#8284
mjsax merged 1 commit intoapache:trunkfrom
jiameixie:rocksdb

Conversation

@jiameixie
Copy link
Copy Markdown
Contributor

Bump rocksdb 5.18.3 to 5.18.4 that supports all platforms.
Issues about this version are facebook/rocksdb#6497
and facebook/rocksdb#6188

Change-Id: I3febec8e36550edcb7f88839cc1e2b2a54984564
Signed-off-by: Jiamei Xie jiamei.xie@arm.com

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Bump rocksdb 5.18.3 to 5.18.4 that supports all platforms.
Issues about this version are facebook/rocksdb#6497
and facebook/rocksdb#6188

Change-Id: I3febec8e36550edcb7f88839cc1e2b2a54984564
Signed-off-by: Jiamei Xie <jiamei.xie@arm.com>
@jiameixie jiameixie changed the title KAFKA-9225: rocksdb 5.18.3 to 5.18.4 KAFKA-9225:Bump rocksdb 5.18.3 to 5.18.4 Mar 12, 2020
@jiameixie jiameixie changed the title KAFKA-9225:Bump rocksdb 5.18.3 to 5.18.4 KAFKA-9225: Bump rocksdb 5.18.3 to 5.18.4 Mar 12, 2020
@ableegoldman
Copy link
Copy Markdown
Member

@jiameixie Thanks for following up! Have you tested this out and verified that it now works with your architecture?

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 12, 2020

Retest this please

@mjsax mjsax added the streams label Mar 12, 2020
Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guozhangwang @vvcephei I guess it's fine to bump RocksDB bug fix version?

Assuming all tests pass, LGTM. We should also run system tests before merging.

@ableegoldman
Copy link
Copy Markdown
Member

ableegoldman commented Mar 12, 2020

Streams system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3832

edit: original run (#3829) failed with some environmental error, kicked off a new run (#3831)
edit 2: someone killed the second run (#3831) so let's try this a third time with #3832

@jiameixie
Copy link
Copy Markdown
Contributor Author

@ableegoldman yes, I have tested it on ARM. It works fine.

@ableegoldman
Copy link
Copy Markdown
Member

Three system tests failed, results here

Two are confirmed to be failing already (the StreamsEOStest) and a quick glimpse at the third (test_standby_tasks_rebalance) seems highly unlikely to be related to this PR, and probably also flaky beforehand. cc/ @mjsax

@mjsax mjsax merged commit 11e6aed into apache:trunk Mar 19, 2020
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 19, 2020

Merged to trunk.

Thanks for the fix @jiameixie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants