KAFKA-9225: Bump rocksdb 5.18.3 to 5.18.4#8284
Conversation
Bump rocksdb 5.18.3 to 5.18.4 that supports all platforms. Issues about this version are facebook/rocksdb#6497 and facebook/rocksdb#6188 Change-Id: I3febec8e36550edcb7f88839cc1e2b2a54984564 Signed-off-by: Jiamei Xie <jiamei.xie@arm.com>
|
@jiameixie Thanks for following up! Have you tested this out and verified that it now works with your architecture? |
|
Retest this please |
mjsax
left a comment
There was a problem hiding this comment.
@guozhangwang @vvcephei I guess it's fine to bump RocksDB bug fix version?
Assuming all tests pass, LGTM. We should also run system tests before merging.
|
Streams system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3832 edit: original run (#3829) failed with some environmental error, kicked off a new run (#3831) |
|
@ableegoldman yes, I have tested it on ARM. It works fine. |
|
Three system tests failed, results here Two are confirmed to be failing already (the |
|
Merged to Thanks for the fix @jiameixie |
Bump rocksdb 5.18.3 to 5.18.4 that supports all platforms.
Issues about this version are facebook/rocksdb#6497
and facebook/rocksdb#6188
Change-Id: I3febec8e36550edcb7f88839cc1e2b2a54984564
Signed-off-by: Jiamei Xie jiamei.xie@arm.com
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)